* [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding
@ 2020-11-27 11:14 Rafał Miłecki
2020-11-27 11:14 ` [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support Rafał Miłecki
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Rafał Miłecki @ 2020-11-27 11:14 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring
Cc: linux-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 was built using older PCIe hardware block that requires using
external reset block controlling PERST# signals.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../reset/brcm,bcm4908-misc-pcie-reset.yaml | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm4908-misc-pcie-reset.yaml
diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm4908-misc-pcie-reset.yaml b/Documentation/devicetree/bindings/reset/brcm,bcm4908-misc-pcie-reset.yaml
new file mode 100644
index 000000000000..88aebb370838
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/brcm,bcm4908-misc-pcie-reset.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reset/brcm,bcm4908-misc-pcie-reset.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom MISC block PCIe reset controller
+
+description: This document describes reset controller handling PCIe PERST#
+ signals. On BCM4908 it's a part of the MISC block.
+
+maintainers:
+ - Rafał Miłecki <rafal@milecki.pl>
+
+properties:
+ compatible:
+ const: brcm,bcm4908-misc-pcie-reset
+
+ reg:
+ maxItems: 1
+
+ "#reset-cells":
+ description: PCIe core id
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - "#reset-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ reset-controller@ff802644 {
+ compatible = "brcm,bcm4908-misc-pcie-reset";
+ reg = <0xff802644 0x04>;
+ #reset-cells = <1>;
+ };
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support
2020-11-27 11:14 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Rafał Miłecki
@ 2020-11-27 11:14 ` Rafał Miłecki
2020-11-28 5:10 ` Florian Fainelli
2020-11-28 5:09 ` [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Florian Fainelli
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2020-11-27 11:14 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring
Cc: linux-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
It's a trivial reset controller. One register with bit per PCIe core.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/reset/Kconfig | 2 +-
drivers/reset/reset-simple.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index b7e377a32c92..f393f7e17e33 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -173,7 +173,7 @@ config RESET_SCMI
config RESET_SIMPLE
bool "Simple Reset Controller Driver" if COMPILE_TEST
- default ARCH_AGILEX || ARCH_ASPEED || ARCH_BITMAIN || ARCH_REALTEK || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARC
+ default ARCH_AGILEX || ARCH_ASPEED || ARCH_BCM4908 || ARCH_BITMAIN || ARCH_REALTEK || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARC
help
This enables a simple reset controller driver for reset lines that
that can be asserted and deasserted by toggling bits in a contiguous,
diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
index e066614818a3..4dda0daf2c6f 100644
--- a/drivers/reset/reset-simple.c
+++ b/drivers/reset/reset-simple.c
@@ -146,6 +146,8 @@ static const struct of_device_id reset_simple_dt_ids[] = {
{ .compatible = "aspeed,ast2500-lpc-reset" },
{ .compatible = "bitmain,bm1880-reset",
.data = &reset_simple_active_low },
+ { .compatible = "brcm,bcm4908-misc-pcie-reset",
+ .data = &reset_simple_active_low },
{ .compatible = "snps,dw-high-reset" },
{ .compatible = "snps,dw-low-reset",
.data = &reset_simple_active_low },
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding
2020-11-27 11:14 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Rafał Miłecki
2020-11-27 11:14 ` [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support Rafał Miłecki
@ 2020-11-28 5:09 ` Florian Fainelli
2020-12-08 19:46 ` Rob Herring
2020-12-09 11:06 ` Philipp Zabel
3 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2020-11-28 5:09 UTC (permalink / raw)
To: Rafał Miłecki, Philipp Zabel, Rob Herring
Cc: linux-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
On 11/27/2020 3:14 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 was built using older PCIe hardware block that requires using
> external reset block controlling PERST# signals.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding
2020-11-27 11:14 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Rafał Miłecki
2020-11-27 11:14 ` [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support Rafał Miłecki
2020-11-28 5:09 ` [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Florian Fainelli
@ 2020-12-08 19:46 ` Rob Herring
2020-12-09 11:06 ` Philipp Zabel
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2020-12-08 19:46 UTC (permalink / raw)
To: Rafał Miłecki
Cc: bcm-kernel-feedback-list, Rafał Miłecki, Philipp Zabel,
devicetree, linux-kernel, Rob Herring
On Fri, 27 Nov 2020 12:14:41 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 was built using older PCIe hardware block that requires using
> external reset block controlling PERST# signals.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../reset/brcm,bcm4908-misc-pcie-reset.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm4908-misc-pcie-reset.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding
2020-11-27 11:14 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Rafał Miłecki
` (2 preceding siblings ...)
2020-12-08 19:46 ` Rob Herring
@ 2020-12-09 11:06 ` Philipp Zabel
3 siblings, 0 replies; 6+ messages in thread
From: Philipp Zabel @ 2020-12-09 11:06 UTC (permalink / raw)
To: Rafał Miłecki, Rob Herring
Cc: linux-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
On Fri, 2020-11-27 at 12:14 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 was built using older PCIe hardware block that requires using
> external reset block controlling PERST# signals.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Thank you, both applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-09 11:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 11:14 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Rafał Miłecki
2020-11-27 11:14 ` [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support Rafał Miłecki
2020-11-28 5:10 ` Florian Fainelli
2020-11-28 5:09 ` [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding Florian Fainelli
2020-12-08 19:46 ` Rob Herring
2020-12-09 11:06 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).