Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes

Nishanth Menon
2020-11-28T22:20:12Z

On 01:40-20201128, Sekhar Nori wrote:
[...]

> - main_usbss0_pins_default: main-usbss0-pins-default {
> + vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
> + >;
> + };
> +
> + main_usbss0_pins_default: main_usbss0_pins_default {

Could you not switch the node name to _ ? We just fixed that
bunch. Now, this patch introduces the following with W=2:
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/vdd_sd_dv_alt_pins_default: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/main_usbss0_pins_default: Character '_' not recommended in node name

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D