From: Rob Herring <robh@kernel.org>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: kernel@pengutronix.de, devicetree@vger.kernel.org,
hverkuil-cisco@xs4all.nl, robh+dt@kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: media: allegro,al5e: Convert to YAML
Date: Mon, 30 Nov 2020 10:00:18 -0700 [thread overview]
Message-ID: <20201130170018.GA2626099@robh.at.kernel.org> (raw)
In-Reply-To: <20201126152941.3825721-3-m.tretter@pengutronix.de>
On Thu, 26 Nov 2020 16:29:39 +0100, Michael Tretter wrote:
> Convert the Allegro DVT video IP codec text binding to Yaml.
>
> Add the converted binding to the MAINTAINERS file.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> .../bindings/media/allegro,al5e.yaml | 95 +++++++++++++++++++
> .../devicetree/bindings/media/allegro.txt | 43 ---------
> MAINTAINERS | 1 +
> 3 files changed, 96 insertions(+), 43 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/allegro,al5e.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/allegro.txt
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/allegro,al5e.yaml:24:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/media/allegro,al5e.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/allegro,al5e.example.dt.yaml: example-0: video-codec@a0009000:reg:0: [0, 2684391424, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/allegro,al5e.example.dt.yaml: example-0: video-codec@a0009000:reg:1: [0, 2684354560, 0, 32768] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/allegro,al5e.example.dt.yaml: example-1: video-codec@a0029000:reg:0: [0, 2684522496, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/allegro,al5e.example.dt.yaml: example-1: video-codec@a0029000:reg:1: [0, 2684485632, 0, 32768] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
See https://patchwork.ozlabs.org/patch/1406739
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-30 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:29 [PATCH 0/4] media: allegro: move driver out of staging Michael Tretter
2020-11-26 15:29 ` [PATCH 1/4] " Michael Tretter
2020-11-26 15:29 ` [PATCH 2/4] dt-bindings: media: allegro,al5e: Convert to YAML Michael Tretter
2020-11-30 17:00 ` Rob Herring [this message]
2020-11-26 15:29 ` [PATCH 3/4] media: allegro: remove custom drain state handling Michael Tretter
2020-11-26 15:29 ` [PATCH 4/4] media: allegro: rename stream_id to dst_handle Michael Tretter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130170018.GA2626099@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).