From: Rob Herring <robh@kernel.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, newbytee@protonmail.com,
Stephan Gerhold <stephan@gerhold.net>,
phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2 v6] dt-bindings: leds: Add DT binding for Richtek RT8515
Date: Mon, 30 Nov 2020 14:49:35 -0700 [thread overview]
Message-ID: <20201130214935.GA3085708@robh.at.kernel.org> (raw)
In-Reply-To: <20201123224543.GC4351@valkosipuli.retiisi.org.uk>
On Tue, Nov 24, 2020 at 12:45:43AM +0200, Sakari Ailus wrote:
> Hi Linus,
>
> On Mon, Nov 23, 2020 at 10:44:38PM +0100, Linus Walleij wrote:
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index f1211e7045f1..92fa90b4a671 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -151,6 +151,12 @@ properties:
> > Maximum flash LED supply current in microamperes. Required for flash LED
> > nodes with configurable current.
> >
> > + torch-max-microamp:
> > + description:
> > + Maximum flash LED supply current in microamperes, when the flash LED is
> > + used as a torch (flashlight). This is usually lower than the flash mode
> > + maximum current, if the LED supports torch mode.
>
> Thanks for the update.
>
> One more thing. The other flash LED DT bindings are using led-max-microamp
> for the torch mode --- for it's what the non-flash LEDs do.
>
> Could you use the same here?
Good point. Seems like it as led-max-microamp should be the max steady
state current whereas flash-max-microamp is the max for a limited time.
Rob
prev parent reply other threads:[~2020-11-30 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 21:44 [PATCH 1/2 v6] dt-bindings: leds: Add DT binding for Richtek RT8515 Linus Walleij
2020-11-23 22:45 ` Sakari Ailus
2020-11-30 21:49 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130214935.GA3085708@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=newbytee@protonmail.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).