From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: adau1372: add missing dependencies
Date: Mon, 30 Nov 2020 22:57:10 +0100 [thread overview]
Message-ID: <20201130215710.GV1296649@piout.net> (raw)
In-Reply-To: <20201130215626.2400999-1-alexandre.belloni@bootlin.com>
On 30/11/2020 22:56:26+0100, Alexandre Belloni wrote:
> SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP
> config they need but forget to depend on the underlying bus.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
I forgot:
Reported-by: kernel test robot <lkp@intel.com>
> ---
> sound/soc/codecs/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index a457300f95da..625f762903ea 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
>
> config SND_SOC_ADAU1372_I2C
> tristate "Analog Devices ADAU1372 CODEC (I2C)"
> + depends on I2C
> select SND_SOC_ADAU1372
> select REGMAP_I2C
>
> config SND_SOC_ADAU1372_SPI
> tristate "Analog Devices ADAU1372 CODEC (SPI)"
> + depends on SPI
> select SND_SOC_ADAU1372
> select REGMAP_SPI
>
> --
> 2.28.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-11-30 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 21:56 [PATCH] ASoC: adau1372: add missing dependencies Alexandre Belloni
2020-11-30 21:57 ` Alexandre Belloni [this message]
2020-12-01 13:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130215710.GV1296649@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).