From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFE9C64E7B for ; Tue, 1 Dec 2020 07:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8D612087D for ; Tue, 1 Dec 2020 07:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727096AbgLAHK6 convert rfc822-to-8bit (ORCPT ); Tue, 1 Dec 2020 02:10:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgLAHK6 (ORCPT ); Tue, 1 Dec 2020 02:10:58 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3A86C0613D2 for ; Mon, 30 Nov 2020 23:10:17 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjznf-0000Bz-1A; Tue, 01 Dec 2020 08:10:11 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kjzne-0006Fw-G9; Tue, 01 Dec 2020 08:10:10 +0100 Date: Tue, 1 Dec 2020 08:10:10 +0100 From: Oleksij Rempel To: Fabio Estevam Cc: Mark Rutland , Rob Herring , Sascha Hauer , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , David Jander Subject: Re: [PATCH v1 2/2] ARM: dts: add Protonic MVT board Message-ID: <20201201071010.e6joif4aoxdy23xg@pengutronix.de> References: <20201130131406.10925-1-o.rempel@pengutronix.de> <20201130131406.10925-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:05:44 up 381 days, 22:24, 51 users, load average: 0.09, 0.06, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 30, 2020 at 10:22:38AM -0300, Fabio Estevam wrote: > Hi Oleksij, > > On Mon, Nov 30, 2020 at 10:14 AM Oleksij Rempel wrote: > > > +&ecspi1 { > > + cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; > > Shouldn't this be GPIO_ACTIVE_LOW instead? ACK, it was fixed up by this code: https://elixir.bootlin.com/linux/v5.10-rc6/source/drivers/gpio/gpiolib-of.c#L210 So, it was still working. Thank you! I'll fix it. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |