From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: conor.dooley@microchip.com
Cc: robh+dt@kernel.org, damien.lemoal@wdc.com,
jassisinghbrar@gmail.com, aou@eecs.berkeley.edu,
paul.walmsley@sifive.com, palmer@dabbelt.com,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
cyril.jean@microchip.com, david.abdurachmanov@gmail.com,
daire.mcnamara@microchip.com, anup.patel@wdc.com,
atish.patra@wdc.com, lewis.hanly@microchip.com
Subject: Re: [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox
Date: Tue, 1 Dec 2020 15:13:28 +0100 [thread overview]
Message-ID: <20201201141328.GJ456020@latitude> (raw)
In-Reply-To: <20201201110242.28369-1-conor.dooley@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On Tue, Dec 01, 2020 at 11:02:42AM +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> This driver adds support for the single mailbox channel of the MSS
> system controller on the Microchip PolarFire SoC.
Out of my curiosity: What is MSS? Is it the Microprocessor Subsystem in
the SoC?
(It isn't quite clear from the PolarFire documentation I could find)
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
[...]
> +config MPFS_MBOX
> + tristate "MPFS Mailbox"
"MPFS" in the title seems (to me) a bit too obscure for the uninitiated.
Perhaps you could use something slightly longer that mentions Microchip
and/or the PolarFire series?
> +++ b/drivers/mailbox/mailbox-mpfs.c
> @@ -0,0 +1,285 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Microchip MPFS system controller/mailbox controller driver
The same might apply here.
Best regards,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-01 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:02 [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox conor.dooley
2020-12-01 11:55 ` Damien Le Moal
2020-12-01 15:54 ` Conor.Dooley
2020-12-01 14:13 ` Jonathan Neuschäfer [this message]
2020-12-01 16:26 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201141328.GJ456020@latitude \
--to=j.neuschaefer@gmx.net \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=damien.lemoal@wdc.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox