From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBB5C64E8A for ; Wed, 2 Dec 2020 04:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF2AB221FA for ; Wed, 2 Dec 2020 04:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387496AbgLBE0f (ORCPT ); Tue, 1 Dec 2020 23:26:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:39050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387454AbgLBE0e (ORCPT ); Tue, 1 Dec 2020 23:26:34 -0500 Date: Wed, 2 Dec 2020 09:55:48 +0530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606883154; bh=51WEf+5cYxqffTJp+/Dq0ME65e1e6IUp0bzqv+ozA/E=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=Gpn4MRy8B2JhLQbiktCY8RadjOVMrsxkt/m6DFUN9Ry+WhBd/Y55zrEvhH5AySwtx K+NIFlOG0OOcT1qP6K+BHdJid+Cp3xt5F/9vjS4cW9PIXcb665y+eRgNw86NdGv/Ad pHyRKxHaa5cc0mmX4rR8gOI0tOgNbX2+sddClf7w= From: Vinod Koul To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi_dma0 node Message-ID: <20201202042548.GE8403@vkoul-mobl> References: <20201201042520.2116271-1-vkoul@kernel.org> <20201201042520.2116271-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01-12-20, 19:06, Bjorn Andersson wrote: > On Mon 30 Nov 22:25 CST 2020, Vinod Koul wrote: > > > gpi_dma0 can be used for spi and i2c transfers on db845c, so enable it > > > > Signed-off-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > > index 7cc236575ee2..0653468f26ce 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > > @@ -418,6 +418,10 @@ &gcc { > > ; > > }; > > > > +&gpi_dma0 { > > + status = "okay"; > > +}; > > + > > But you're only enabling the gpi, you don't have anything wired to it, > so why enable it? > > I took a look downstream and they have all the i2c and spi nodes with > their dmas filled out - and the two gpis enabled at all times > (sdm845.dtsi). Can/should we do the same? So dma is merged and in linux-next but support for spi/i2c is not as that is dependent upon dmaengine interface introduced for this. I was planning to post spi/i2c after rc1 and also the dts enabling them -- ~Vinod