From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF96C71156 for ; Wed, 2 Dec 2020 15:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11C9A206CA for ; Wed, 2 Dec 2020 15:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730390AbgLBPK3 (ORCPT ); Wed, 2 Dec 2020 10:10:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730378AbgLBPK2 (ORCPT ); Wed, 2 Dec 2020 10:10:28 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4002C0613CF for ; Wed, 2 Dec 2020 07:09:47 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a3so8944150wmb.5 for ; Wed, 02 Dec 2020 07:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oOSicCWhNpoN2Xb8hfcdhiDNzylSo2X/NngolxOC8vQ=; b=VDelKcaY4dVlNWOPXMkFf5mSXUkNLpgLiq61inVRo15dob72+uGh1D9f5e4VkqWOzI u0EHXHU0xohcCj4fmAeQeKP3TXa+vjSI8eNdR74HCDe+UHd9U/DGkrpts1l5adsgcqRQ nfawWVLe5huBvNv3/DutS9t31Sr2Xr9Z01YLLlIxupe+KJnOZK9uRi4CROMt46bfcEYk lqZD+9hDlvOIJs67RAEup4JAo8+NuIgARwg97o7VFnRkSVnMbiXA/FV7aVvtTp2ielGk 6kScFx954N9zYr98z5jyAfvmvdp4VwaaaudFbytw/6KBilM4p6zn/3BR8b/mdXllr5Sa 2png== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oOSicCWhNpoN2Xb8hfcdhiDNzylSo2X/NngolxOC8vQ=; b=c0h7CsWTwAmfBT5EDmo5TmSsaZC/yCvDoYJATjXXFwvCkTmExPYXcdRepLSLLRHYNK c5J0mVrH6xCFAm/6JzXJSbqQd7spBmln4c1gzOk6UXMsdPOAyl4ofpWpaTZefUaJGVw+ 5ZgDOHSWYeRFWrK/C57Qjdpi0WdSCkph1s17MrYNOyWb5wR7ZiDJkAWBCiAg1JGuiUq1 z1cih7HgT4BMy/m7dzT+gkABxGnjR8QabZHZmTNFrV4tE0dh/IiLe0ON2oxD/PGzyTRH N7HW/gMSMvp/eXG5kwdLGsidx6es8G54KZzr5jbAkwvlVS+F1b/+FRdqdkieyrbLal6d 3htg== X-Gm-Message-State: AOAM533zrjQeGgr/r4Aj/jqtBVx7HEQRNBa6SPa89qU++L1f8goR9Vhh JmJJzT/xUM9Nis6kUUMFb+/9aQ== X-Google-Smtp-Source: ABdhPJyY6iTjOclycbgMdZR1BJM/NQs428i4F9BST8rtkZMQKzAhUor3EpfauPJw0gENxlNhnY3zKw== X-Received: by 2002:a7b:c19a:: with SMTP id y26mr2548794wmi.20.1606921786422; Wed, 02 Dec 2020 07:09:46 -0800 (PST) Received: from dell ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s4sm2676916wra.91.2020.12.02.07.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 07:09:45 -0800 (PST) Date: Wed, 2 Dec 2020 15:09:43 +0000 From: Lee Jones To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded controller Message-ID: <20201202150943.GN4801@dell> References: <20201122222739.1455132-1-j.neuschaefer@gmx.net> <20201122222739.1455132-4-j.neuschaefer@gmx.net> <20201202130520.GL4801@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 02 Dec 2020, Jonathan Neuschäfer wrote: > On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote: > > On Sun, 22 Nov 2020, Jonathan Neuschäfer wrote: > [...] > > > + /* Bail out if we encounter an unknown firmware version */ > > > + switch (version) { > > > + case 0xd726: /* found in Kobo Aura */ > > > > No magic numbers. > > > > Please submit a subsequent patch to define this. > > Will do. > > But I don't think I'll be able to give it a more meaningful name than > NTXEC_VERSION_D726. I don't have a good overview of which versions > appear in which devices. "0xd726 found in Kobo Aura" only means that; > I don't know if it's the only version used in the Kobo Aura, and I don't > know if the Kobo Aura is the only device where it is used. Defines are not set in stone. They can evolve over time as more is known. NTXEC_KOBO_AURA would be fine for now. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog