From: Vladimir Oltean <olteanv@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Christian Eggers <ceggers@arri.de>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Rob Herring <robh+dt@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
George McCollister <george.mccollister@gmail.com>,
Marek Vasut <marex@denx.de>,
Helmut Grohne <helmut.grohne@intenta.de>,
Paul Barker <pbarker@konsulko.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Tristram Ha <Tristram.Ha@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support
Date: Fri, 4 Dec 2020 03:00:50 +0200 [thread overview]
Message-ID: <20201204010050.xbu23yynlwt7jskg@skbuf> (raw)
In-Reply-To: <20201204004556.GB18560@hoboy.vegasvil.org>
On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote:
> On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote:
> > Should ptp_sysfs be extended with a "pulse" attribute with calls
> > enable() with only PTP_PEROUT_DUTY_CYCLE set?
>
> Yes, that would make sense. It would bring sysfs back to feature
> parity with the ioctls.
Which is a good thing?
Anyway, Christian, if you do decide to do that, here's some context why
I didn't do it when I added the additional knobs for periodic output:
https://www.mail-archive.com/linuxptp-devel@lists.sourceforge.net/msg04150.html
next prev parent reply other threads:[~2020-12-04 1:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 10:21 [PATCH net-next v5 0/9] net: dsa: microchip: PTP support for KSZ956x Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property Christian Eggers
2020-12-09 20:09 ` Rob Herring
2020-12-03 10:21 ` [PATCH net-next v5 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init() Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 4/9] net: dsa: microchip: ksz9477: basic interrupt support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 6/9] net: ptp: add helper for one-step P2P clocks Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 8/9] net: dsa: microchip: ksz9477: remaining " Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support Christian Eggers
2020-12-03 14:12 ` Richard Cochran
2020-12-03 15:36 ` Christian Eggers
2020-12-03 15:52 ` Vladimir Oltean
2020-12-03 16:20 ` Christian Eggers
2020-12-04 0:45 ` Richard Cochran
2020-12-04 1:00 ` Vladimir Oltean [this message]
2020-12-04 1:18 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204010050.xbu23yynlwt7jskg@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ceggers@arri.de \
--cc=codrin.ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=george.mccollister@gmail.com \
--cc=helmut.grohne@intenta.de \
--cc=kuba@kernel.org \
--cc=kurt.kanzenbach@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pbarker@konsulko.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox