Re: [PATCH v9 0/3] Use the generic PHY framework for Ingenic USB PHY.

Vinod Koul
2020-12-05T08:23:55Z

On 16-11-20, 22:19, 周琰杰 (Zhou Yanjie) wrote:
> v3->v4:
> Only add new generic-PHY driver, without removing the old one. Because the
> jz4740-musb driver is not ready to use the generic PHY framework. When the
> jz4740-musb driver is modified to use the generic PHY framework, the old
> jz4770-phy driver can be "retired".
>
> v4->v5:
> 1.Add an extra blank line between "devm_of_phy_provider_register" and "return".
> 2.Remove unnecessary "phy_set_drvdata".
> 3.Add Paul Cercueil's Reviewed-by.
>
> v5->v6:
> 1.Revert the removal of "phy_set_drvdata" in v5, removing "phy_set_drvdata" will
> cause a kernel panic on CI20.
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> 2.Rewrite the macro definitions, replace the original code with "FIELD_PREP()"
> and "u32p_replace_bits()" according to Vinod Koul's suggestion.
>
> v6->v7:
> 1.Remove the stray tab character.
> 2.Remove unnecessary "platform_set_drvdata".
> 3.Remove the "dev" field in priv structure, and use &phy->dev instead.
>
> v7->v8:
> Add support for Ingenic JZ4775 SoC and X2000 SoC.
>
> v8->v9:
> Correct the path errors in "ingenic,phy-usb.yaml" and "ingenic,cgu.yaml".

Applied, thanks

--
~Vinod