From: Krzysztof Kozlowski <krzk@kernel.org>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 3/4] bindings: arm: fsl: Add PHYTEC i.MX8MP devicetree bindings
Date: Mon, 7 Dec 2020 12:59:58 +0100 [thread overview]
Message-ID: <20201207115958.GA27266@kozik-lap> (raw)
In-Reply-To: <1607113982-109524-4-git-send-email-t.remmet@phytec.de>
On Fri, Dec 04, 2020 at 09:33:01PM +0100, Teresa Remmet wrote:
> Add devicetree bindings for i.MX8MP based phyCORE-i.MX8MP
> and phyBOARD-Pollux RDK.
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 934289446abb..880d93092f37 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -433,6 +433,13 @@ properties:
> - fsl,imx8mp-evk # i.MX8MP EVK Board
> - const: fsl,imx8mp
>
> + - description: PHYTEC phyCORE-i.MX8MP SoM based boards
> + items:
> + - enum:
> + - phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM
> + - phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-Pollux RDK
These do not look correct. In this way, you should include them in
"i.MX8MP based Boards" entry. Probably you wanted all "const" instead.
Best regards,
Krzysztof
> + - const: fsl,imx8mp
> +
next prev parent reply other threads:[~2020-12-07 12:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 20:32 [PATCH 0/4] Initial support for phyBOARD-Pollux i.MX8MP Teresa Remmet
2020-12-04 20:32 ` [PATCH 1/4] arm64: defconfig: Enable rv3028 i2c rtc driver Teresa Remmet
2020-12-07 12:10 ` Krzysztof Kozlowski
2020-12-07 13:38 ` Teresa Remmet
2020-12-07 13:50 ` Krzysztof Kozlowski
2020-12-08 11:33 ` Teresa Remmet
2020-12-04 20:33 ` [PATCH 2/4] arm64: defconfig: Enable PCA9532 support Teresa Remmet
2020-12-07 12:11 ` Krzysztof Kozlowski
2020-12-04 20:33 ` [PATCH 3/4] bindings: arm: fsl: Add PHYTEC i.MX8MP devicetree bindings Teresa Remmet
2020-12-07 11:59 ` Krzysztof Kozlowski [this message]
2020-12-07 12:37 ` Teresa Remmet
2020-12-04 20:33 ` [PATCH 4/4] arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP Teresa Remmet
2020-12-07 12:09 ` Krzysztof Kozlowski
2020-12-07 13:35 ` Teresa Remmet
2020-12-07 13:46 ` Krzysztof Kozlowski
2020-12-08 11:53 ` Teresa Remmet
2020-12-08 12:00 ` Krzysztof Kozlowski
2020-12-08 12:23 ` Teresa Remmet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207115958.GA27266@kozik-lap \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).