From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: damien.lemoal@wdc.com, jassisinghbrar@gmail.com,
aou@eecs.berkeley.edu, paul.walmsley@sifive.com,
palmer@dabbelt.com, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, lewis.hanly@microchip.com,
cyril.jean@microchip.com, daire.mcnamara@microchip.com,
atish.patra@wdc.com, anup.patel@wdc.com,
david.abdurachmanov@gmail.com
Subject: Re: [PATCH v2 4/5] dt-bindings: add bindings for polarfire soc system controller
Date: Mon, 7 Dec 2020 09:56:57 -0600 [thread overview]
Message-ID: <20201207155657.GB345332@robh.at.kernel.org> (raw)
In-Reply-To: <20201201110311.28593-1-conor.dooley@microchip.com>
On Tue, Dec 01, 2020 at 11:03:11AM +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the MSS system controller on
> the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../microchip,mpfs_sys_controller.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml
> new file mode 100644
> index 000000000000..c22fc203b95c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/microchip/microchip,mpfs_sys_controller.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Microchip MPFS system controller
> +
> +maintainers:
> + - Conor Dooley <conor.dooley@microchip.com>
> +
> +properties:
> + compatible:
> + const: microchip,polarfire-soc-sys-controller
> +
> + mbox-names:
> + maxItems: 1
> + description: name of the mailbox controller device node
Kind of pointless to have names when there is only one entry. I'd drop,
but if you do, you need to define what the name is.
> +
> + mboxes:
> + maxItems: 1
> + description: |
> + phandle and index of the mailbox controller device node. It must be 0 (hardware supports only one channel).
No need to redefine a common property. And the value 0 is outside the
scope of this binding. That's dependent on the mbox h/w.
> +
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
These are not needed unless you have child nodes. If you do, then they
also need to be defined here.
> +
> +required:
> + - compatible
> + - mbox-names
> + - "#address-cells"
> + - "#size-cells"
> + - "mboxes"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + syscontroller: syscontroller {
> + compatible = "microchip,polarfire-soc-sys-controller";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + mbox-names = "mbox-mpfs";
> + mboxes = <&mbox 0>;
> + };
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-12-07 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:03 [PATCH v2 4/5] dt-bindings: add bindings for polarfire soc system controller conor.dooley
2020-12-07 15:53 ` Rob Herring
2020-12-07 15:56 ` Rob Herring [this message]
2020-12-15 16:10 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207155657.GB345332@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=damien.lemoal@wdc.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).