devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: linux-kernel@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
	Alistair Francis <alistair.francis@wdc.com>,
	Anup Patel <anup.patel@wdc.com>,
	Bin Meng <bin.meng@windriver.com>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Ivan.Griffin@microchip.com, Cyril.Jean@microchip.com,
	Daire McNamara <daire.mcnamara@microchip.com>,
	Conor.Dooley@microchip.com
Subject: Re: [PATCH v3 2/5] dt-bindings: riscv: microchip: Add YAML documentation for the PolarFire SoC
Date: Wed, 9 Dec 2020 17:30:11 -0600	[thread overview]
Message-ID: <20201209233011.GA1276461@robh.at.kernel.org> (raw)
In-Reply-To: <20201204085835.2406541-3-atish.patra@wdc.com>

On Fri, Dec 04, 2020 at 12:58:32AM -0800, Atish Patra wrote:
> Add YAML DT binding documentation for the Microchip PolarFire SoC.
> It is documented at:
> 
> https://www.microsemi.com/products/fpga-soc/polarfire-soc-icicle-quick-start-guide
> 
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
>  .../devicetree/bindings/riscv/microchip.yaml  | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/microchip.yaml
> 
> diff --git a/Documentation/devicetree/bindings/riscv/microchip.yaml b/Documentation/devicetree/bindings/riscv/microchip.yaml
> new file mode 100644
> index 000000000000..66e63c2bf359
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/microchip.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)

See what checkpatch.pl says.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/microchip.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PolarFire SoC-based boards device tree bindings
> +
> +maintainers:
> +  - Cyril Jean <Cyril.Jean@microchip.com>
> +  - Lewis Hanly <lewis.hanly@microchip.com>
> +
> +description:
> +  Microchip PolarFire SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    items:
> +      - enum:
> +          - microchip,mpfs-icicle-kit
> +      - const: microchip,polarfire-soc
> +      - const: microchip,mpfs

Is this last compatible really useful? Usually better to just have SoC 
and board (or SoM plus baseboard) compatibles.

Rob

  reply	other threads:[~2020-12-09 23:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  8:58 [PATCH v3 0/5] Add Microchip PolarFire Soc Support Atish Patra
2020-12-04  8:58 ` [PATCH v3 1/5] RISC-V: Add Microchip PolarFire SoC kconfig option Atish Patra
2021-01-07 11:39   ` Cyril.Jean
2021-01-07 19:21     ` Atish Patra
2020-12-04  8:58 ` [PATCH v3 2/5] dt-bindings: riscv: microchip: Add YAML documentation for the PolarFire SoC Atish Patra
2020-12-09 23:30   ` Rob Herring [this message]
2020-12-04  8:58 ` [PATCH v3 3/5] RISC-V: Initial DTS for Microchip ICICLE board Atish Patra
2020-12-10 11:06   ` Bin Meng
2021-01-07 11:43   ` Cyril.Jean
2021-01-07 19:26     ` Atish Patra
2020-12-04  8:58 ` [PATCH v3 4/5] RISC-V: Enable Microchip PolarFire ICICLE SoC Atish Patra
2020-12-26  0:37   ` Aurelien Jarno
2020-12-04  8:58 ` [PATCH v3 5/5] MAINTAINERS: add microchip polarfire soc support Atish Patra
2020-12-10 11:08   ` Bin Meng
2020-12-22  3:19 ` [PATCH v3 0/5] Add Microchip PolarFire Soc Support Palmer Dabbelt
2020-12-22 20:14   ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209233011.GA1276461@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Conor.Dooley@microchip.com \
    --cc=Cyril.Jean@microchip.com \
    --cc=Ivan.Griffin@microchip.com \
    --cc=alistair.francis@wdc.com \
    --cc=anup.patel@wdc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).