From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885CCC4361B for ; Thu, 10 Dec 2020 03:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B82F23A1D for ; Thu, 10 Dec 2020 03:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729414AbgLJDct (ORCPT ); Wed, 9 Dec 2020 22:32:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729136AbgLJDcs (ORCPT ); Wed, 9 Dec 2020 22:32:48 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A23EC0613CF for ; Wed, 9 Dec 2020 19:32:08 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id o5so2892632pgm.10 for ; Wed, 09 Dec 2020 19:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kei1zI7Wc1yA9DIt1u6wEo8G7ei+JB/TuTW/pNfEG38=; b=GXW8aihJdzl/BXXv+P3XGw3leUud7Fus0B3jXf8co2YxUx7CxB7wwgkxkgTAhRDc3n N4+9lVP50nG43dew+HEw2geYOqZtcn3hCJahGwvPUfUvxr52HWsdsE8pdtOsHkz9HHVx FqW21EY2dq5i9P/B+xWHVfGmkfoNdCbwEY7ySLvXfNKqa5hsl6P6vQh+puxHMfTtTPoO HB6ydqFv+nYyV2LS91STJWoW7jrwgtqW2w6UUSu3RQ4c67kNz5HEA6LeykLwnznZKJBO 2nBi1FRFVQO5gvfJqSX51BkSLJ3uq1jtuljmqgzLvEnNHWlBKDezfBz7aRzsdzVUhhqu +lFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kei1zI7Wc1yA9DIt1u6wEo8G7ei+JB/TuTW/pNfEG38=; b=IHiKuN5B1g4LD5jVT4/urS+YS9BY/Xyu47MvT5k6g6AHnYQxOcxs181GbXl8JHGw9k z6t/bZbh+uxAhCjwDIcYRDcicmLgfJDxIwokp4+yk+F3LKdV87stEIi2xSj/KNHWtl8c SRqCODbIV4Zi7Ebs0NYo6gDegP94dXDHj7B1AMqeqKim95ER5BB0HV8WXRyDl2LWef9D ZC54OMww7zHIqxt64ZB6mhoGu39gYPVjaVzEGFkKtQp9dHHcDPk0BWpV/qJlu+p+ZnwK /d3y84OAsSNiBCGhbEqgDev9QHtN9bnyJg7DKEFvlGkArQX8VBZBKJ/QfcwritHgtazO iclg== X-Gm-Message-State: AOAM533GVmFtaKJAmDqfw+8ouDtcuokXY4OImxh9Bg6XVGxh2JIlzYdX T1jCTVa3GOnozXLfnCvQkKuv X-Google-Smtp-Source: ABdhPJzhwTaG20AqfqOFYAIot99tvXjpCBa9y5FySoibVEXxG91zkufEi3DI3EfSwl/CD6db7xR3Jw== X-Received: by 2002:a17:90a:d145:: with SMTP id t5mr840291pjw.104.1607571128145; Wed, 09 Dec 2020 19:32:08 -0800 (PST) Received: from thinkpad ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id w9sm3932422pjq.0.2020.12.09.19.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 19:32:07 -0800 (PST) Date: Thu, 10 Dec 2020 09:01:57 +0530 From: Manivannan Sadhasivam To: Zhen Lei Cc: Pavel Machek , Dan Murphy , Rob Herring , linux-leds , devicetree , linux-kernel , Darshak Patel , Shawn Guo , Dong Aisheng , Guodong Xu , Wei Xu , Linus Walleij , Lad Prabhakar , Marian-Cristian Rotariu , Geert Uytterhoeven , Heiko Stuebner Subject: Re: [PATCH 1/1] dt-bindings: leds: add onboard LED triggers of 96Boards Message-ID: <20201210033157.GA6466@thinkpad> References: <20201210031203.1901-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210031203.1901-1-thunder.leizhen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Thu, Dec 10, 2020 at 11:12:03AM +0800, Zhen Lei wrote: > For all 96Boards, the following standard is used for onboard LEDs. > > green:user1 default-trigger: heartbeat > green:user2 default-trigger: mmc0/disk-activity(onboard-storage) > green:user3 default-trigger: mmc1 (SD-card) > green:user4 default-trigger: none, panic-indicator > yellow:wlan default-trigger: phy0tx > blue:bt default-trigger: hci0-power > > Link to 96Boards CE Specification: https://linaro.co/ce-specification > This is just a board configuration and there is absolutely no need to document this in common LED binding. But if your intention is to document the missing triggers, then you should look at the patch I submitted long ago. https://lore.kernel.org/patchwork/patch/1146359/ Maybe I should resubmit it again in YAML format. (thanks for reminding me :P) Thanks, Mani > Signed-off-by: Zhen Lei > Cc: Darshak Patel > Cc: Manivannan Sadhasivam > Cc: Shawn Guo > Cc: Dong Aisheng > Cc: Guodong Xu > Cc: Wei Xu > Cc: Linus Walleij > Cc: Lad Prabhakar > Cc: Marian-Cristian Rotariu > Cc: Geert Uytterhoeven > Cc: Heiko Stuebner > --- > Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index f1211e7045f12f3..525752d6c5c84fd 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -97,6 +97,16 @@ properties: > # LED alters the brightness for the specified duration with one software > # timer (requires "led-pattern" property) > - pattern > + #For all 96Boards, Green, disk-activity(onboard-storage) > + - mmc0 > + #For all 96Boards, Green, SD-card > + - mmc1 > + #For all 96Boards, Green, panic-indicator > + - none > + #For all 96Boards, Yellow, WiFi activity LED > + - phy0tx > + #For all 96Boards, Blue, Bluetooth activity LED > + - hci0-power > > led-pattern: > description: | > -- > 1.8.3 > >