From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Document commonly used LED triggers
Date: Thu, 10 Dec 2020 12:56:44 +0530 [thread overview]
Message-ID: <20201210072644.GB24867@work> (raw)
In-Reply-To: <a1dde00a-3b39-51c5-b15a-d9cd56ba969c@huawei.com>
On Thu, Dec 10, 2020 at 02:57:09PM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2020/12/10 14:14, Manivannan Sadhasivam wrote:
> > This commit documents the LED triggers used commonly in the SoCs. Not
> > all triggers are documented as some of them are very application specific.
> > Most of the triggers documented here are currently used in devicetrees
> > of many SoCs.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > .../devicetree/bindings/leds/common.yaml | 72 ++++++++++++++-----
> > 1 file changed, 54 insertions(+), 18 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index f1211e7045f1..eee4eb7a4535 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -79,24 +79,60 @@ properties:
> > the LED.
> > $ref: /schemas/types.yaml#definitions/string
> >
> > - enum:
> > - # LED will act as a back-light, controlled by the framebuffer system
> > - - backlight
> > - # LED will turn on (but for leds-gpio see "default-state" property in
> > - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> > - - default-on
> > - # LED "double" flashes at a load average based rate
> > - - heartbeat
> > - # LED indicates disk activity
> > - - disk-activity
> > - # LED indicates IDE disk activity (deprecated), in new implementations
> > - # use "disk-activity"
> > - - ide-disk
> > - # LED flashes at a fixed, configurable rate
> > - - timer
> > - # LED alters the brightness for the specified duration with one software
> > - # timer (requires "led-pattern" property)
> > - - pattern
> > + oneOf:
> > + - items:
> > + - enum:
> > + # LED will act as a back-light, controlled by the framebuffer system
> > + - backlight
> > + # LED will turn on (but for leds-gpio see "default-state" property in
> > + # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> > + - default-on
> > + # LED "double" flashes at a load average based rate
> > + - heartbeat
> > + # LED indicates disk activity
> > + - disk-activity
> > + # LED indicates IDE disk activity (deprecated), in new implementations
> > + # use "disk-activity"
> > + - ide-disk
> > + # LED flashes at a fixed, configurable rate
> > + - timer
> > + # LED alters the brightness for the specified duration with one software
> > + # timer (requires "led-pattern" property)
> > + - pattern
> > + # LED indicates camera flash state
> > + - flash
> > + # LED indicates camera torch state
> > + - torch
> > + # LED indicates audio mute state
> > + - audio-mute
> > + # LED indicates mic mute state
> > + - audio-micmute
> > + # LED indicates bluetooth power state
> > + - bluetooth-power
> > + # LED indicates USB gadget activity
> > + - usb-gadget
> > + # LED indicates USB host activity
> > + - usb-host
> > + # LED indicates MTD memory activity
> > + - mtd
> > + # LED indicates NAND memory activity (deprecated),
> > + # in new implementations use "mtd"
> > + - nand-disk
> > + # LED indicates disk read activity
> > + - disk-read
> > + # LED indicates disk write activity
> > + - disk-write
> > + # No trigger assigned to the LED. This is the default mode
> > + # if trigger is absent
> > + - none
> > + # LED indicates activity of all CPUs
> > + - cpu
> The triggers phy0tx and hci0-power are missed.
>
Yes, I just reworked my previous patch. Will add them.
> Since you've rewritten it, please consider sorting these property strings
> in ascending alphabetical order.
>
Makes sense!
> > + - items:
> > + # LED indicates activity of [N]th CPU
> > + - pattern: "^cpu[0-9][0-9]$"
> should be ^cpu[0-9]{1,2}$, otherwise, it always requires two digit.
>
Aww... Yes. Will fix it.
> > + - items:
> > + # LED indicates [N]th MMC storage activity
> > + - pattern: '^mmc[0-9][0-9]$'
> should be '^mmc[0-9]{1,2}$'
>
> Why CPU use "", and mmc use ''，It's better to keep them consistent.
>
Sure.
Thanks,
Mani
> >
> > led-pattern:
> > description: |
> >
>
prev parent reply other threads:[~2020-12-10 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 6:14 [PATCH] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2020-12-10 6:57 ` Leizhen (ThunderTown)
2020-12-10 7:26 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210072644.GB24867@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).