From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA46FC433FE for ; Thu, 10 Dec 2020 07:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73A6623D23 for ; Thu, 10 Dec 2020 07:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729108AbgLJH1c (ORCPT ); Thu, 10 Dec 2020 02:27:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbgLJH1b (ORCPT ); Thu, 10 Dec 2020 02:27:31 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A63C0613CF for ; Wed, 9 Dec 2020 23:26:51 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id bj5so2335106plb.4 for ; Wed, 09 Dec 2020 23:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=USRN4aJ9sEiwZlAROLtbHMelBYyYvpQx6lROZQiOzA8=; b=hkVuSfU9fqbO/mAIKd/SjkUpzsu9LuCmVTvEjmE/Py3Gxu9BhrTwFz8Pr7phiPwME5 I5l1vc3ovDC+8Zx88mKIn/a2ohgNcKsM4J8Qkexm1IMYedSeItW7IJJMBmPhc6gl84N5 LgWv3lU/X0pudSbkCTYKJBEoO5oGUae/jYYJfXbIXwTmj2QHYk1EltT0fWmmeIqgwwm5 5YLN9aqp2esbW2IQIrWZVXLj9K1E60lY4Xqyu61ivLLkmeUwKggM3+iltgvpcJbBIg5c tAspDnaL4kU9RLD3tdHaaAL/Q77HXbeEOnTXnrbNAycFlKj0OmjZZJAQwwEImj79DXPs GqQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=USRN4aJ9sEiwZlAROLtbHMelBYyYvpQx6lROZQiOzA8=; b=a8UT5AcOGvVNrXR4QDCo7waYqJAbDvh+33wL1z76DD+TSXqAcPO4UpP77UjRoMWKqw TZOF7TKmLBJVThjg8ykcH23m8F8DOERz2zb/07jRbZvgsq8D85mZs3YEp6XrxbY0jrEz LRfa34XEY0J6sM5UCcj7nrtKl6wMQKJZKL24qxZy3cqZsTR9daZzSX0JbMbs3A2yLNJS CDEVQisKMsdPzfmg81f6FuEvXXuJ26F+lgK3PVE/P4VpOpY/PqiBy3fTXqymgkeLU6zm Ao3epgHuftnyVdtKWDd6jlTKyedHC7NpbeDs612rauNKMYGHAjOg8xnDWsXGb37p3gze nHsg== X-Gm-Message-State: AOAM533LTim3+6i0pMs8Tq7CK4mHXDo695jx81PwW7i05fSNHWiens4x LfLXcATW2QlY0duy3Ln9KR26 X-Google-Smtp-Source: ABdhPJzPTDQurAJCyHKdzr+BPaiXOBf9afAP4bocl6Le0+PDarDPhWFOXRbIlzSYHzuqW55uliX8+g== X-Received: by 2002:a17:902:bd01:b029:da:5bec:9ca2 with SMTP id p1-20020a170902bd01b02900da5bec9ca2mr5671698pls.62.1607585210950; Wed, 09 Dec 2020 23:26:50 -0800 (PST) Received: from work ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id gk4sm1838451pjb.57.2020.12.09.23.26.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Dec 2020 23:26:50 -0800 (PST) Date: Thu, 10 Dec 2020 12:56:44 +0530 From: Manivannan Sadhasivam To: "Leizhen (ThunderTown)" Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH] dt-bindings: leds: Document commonly used LED triggers Message-ID: <20201210072644.GB24867@work> References: <20201210061431.23144-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 10, 2020 at 02:57:09PM +0800, Leizhen (ThunderTown) wrote: > > > On 2020/12/10 14:14, Manivannan Sadhasivam wrote: > > This commit documents the LED triggers used commonly in the SoCs. Not > > all triggers are documented as some of them are very application specific. > > Most of the triggers documented here are currently used in devicetrees > > of many SoCs. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > .../devicetree/bindings/leds/common.yaml | 72 ++++++++++++++----- > > 1 file changed, 54 insertions(+), 18 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > > index f1211e7045f1..eee4eb7a4535 100644 > > --- a/Documentation/devicetree/bindings/leds/common.yaml > > +++ b/Documentation/devicetree/bindings/leds/common.yaml > > @@ -79,24 +79,60 @@ properties: > > the LED. > > $ref: /schemas/types.yaml#definitions/string > > > > - enum: > > - # LED will act as a back-light, controlled by the framebuffer system > > - - backlight > > - # LED will turn on (but for leds-gpio see "default-state" property in > > - # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > > - - default-on > > - # LED "double" flashes at a load average based rate > > - - heartbeat > > - # LED indicates disk activity > > - - disk-activity > > - # LED indicates IDE disk activity (deprecated), in new implementations > > - # use "disk-activity" > > - - ide-disk > > - # LED flashes at a fixed, configurable rate > > - - timer > > - # LED alters the brightness for the specified duration with one software > > - # timer (requires "led-pattern" property) > > - - pattern > > + oneOf: > > + - items: > > + - enum: > > + # LED will act as a back-light, controlled by the framebuffer system > > + - backlight > > + # LED will turn on (but for leds-gpio see "default-state" property in > > + # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > > + - default-on > > + # LED "double" flashes at a load average based rate > > + - heartbeat > > + # LED indicates disk activity > > + - disk-activity > > + # LED indicates IDE disk activity (deprecated), in new implementations > > + # use "disk-activity" > > + - ide-disk > > + # LED flashes at a fixed, configurable rate > > + - timer > > + # LED alters the brightness for the specified duration with one software > > + # timer (requires "led-pattern" property) > > + - pattern > > + # LED indicates camera flash state > > + - flash > > + # LED indicates camera torch state > > + - torch > > + # LED indicates audio mute state > > + - audio-mute > > + # LED indicates mic mute state > > + - audio-micmute > > + # LED indicates bluetooth power state > > + - bluetooth-power > > + # LED indicates USB gadget activity > > + - usb-gadget > > + # LED indicates USB host activity > > + - usb-host > > + # LED indicates MTD memory activity > > + - mtd > > + # LED indicates NAND memory activity (deprecated), > > + # in new implementations use "mtd" > > + - nand-disk > > + # LED indicates disk read activity > > + - disk-read > > + # LED indicates disk write activity > > + - disk-write > > + # No trigger assigned to the LED. This is the default mode > > + # if trigger is absent > > + - none > > + # LED indicates activity of all CPUs > > + - cpu > The triggers phy0tx and hci0-power are missed. > Yes, I just reworked my previous patch. Will add them. > Since you've rewritten it, please consider sorting these property strings > in ascending alphabetical order. > Makes sense! > > + - items: > > + # LED indicates activity of [N]th CPU > > + - pattern: "^cpu[0-9][0-9]$" > should be ^cpu[0-9]{1,2}$, otherwise, it always requires two digit. > Aww... Yes. Will fix it. > > + - items: > > + # LED indicates [N]th MMC storage activity > > + - pattern: '^mmc[0-9][0-9]$' > should be '^mmc[0-9]{1,2}$' > > Why CPU use "", and mmc use ''，It's better to keep them consistent. > Sure. Thanks, Mani > > > > led-pattern: > > description: | > > >