[PATCH 0/3] PineTab with new panel DT

[PATCH 0/3] PineTab with new panel DT

[Icenowy Zheng]

As discussed on the mailing list, here introduces a new DT for new
PineTabs.

Icenowy Zheng (3):
  dt-bindings: arm: sunxi: add PineTab new panel DT binding
  arm64: allwinner: dts: a64: add DT for PineTab with new LCD panel
  dt-bindings: arm: sunxi: note that old PineTab compatible has old
    panel

 .../devicetree/bindings/arm/sunxi.yaml        |  7 ++++-
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../sun50i-a64-pinetab-new-panel.dts          | 26 +++++++++++++++++++
 3 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-new-panel.dts

-- 
2.28.0

[PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Icenowy Zheng]

Early adopters' PineTabs (and all further releases) will have a new LCD
panel different with the one that is used when in development (because
the old panel's supply discontinued).

Add a new DT compatible for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 6db32fbf813f..73a6c8421172 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -700,6 +700,11 @@ properties:
           - const: pine64,pinetab
           - const: allwinner,sun50i-a64
 
+      - description: Pine64 PineTab with new LCD panel
+        items:
+          - const: pine64,pinetab-new-panel
+          - const: allwinner,sun50i-a64
+
       - description: Pine64 SoPine Baseboard
         items:
           - const: pine64,sopine-baseboard
-- 
2.28.0

Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Rob Herring]

On Thu, 10 Dec 2020 16:42:32 +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
> 
> Add a new DT compatible for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
> 
> Add a new DT compatible for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 6db32fbf813f..73a6c8421172 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -700,6 +700,11 @@ properties:
>            - const: pine64,pinetab
>            - const: allwinner,sun50i-a64
>  
> +      - description: Pine64 PineTab with new LCD panel
> +        items:
> +          - const: pine64,pinetab-new-panel
> +          - const: allwinner,sun50i-a64
> +

We're on the right track, but new panel seems a bit too vague. What is
going to happen when they will change the panel again?

pinetab-early-adopter seems more robust there

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [linux-sunxi] Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Icenowy Zheng]

于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech> 写到:
>On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
>> Early adopters' PineTabs (and all further releases) will have a new
>LCD
>> panel different with the one that is used when in development
>(because
>> the old panel's supply discontinued).
>> 
>> Add a new DT compatible for it.
>> 
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
>b/Documentation/devicetree/bindings/arm/sunxi.yaml
>> index 6db32fbf813f..73a6c8421172 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
>> @@ -700,6 +700,11 @@ properties:
>>            - const: pine64,pinetab
>>            - const: allwinner,sun50i-a64
>>  
>> +      - description: Pine64 PineTab with new LCD panel
>> +        items:
>> +          - const: pine64,pinetab-new-panel
>> +          - const: allwinner,sun50i-a64
>> +
>
>We're on the right track, but new panel seems a bit too vague. What is
>going to happen when they will change the panel again?
>
>pinetab-early-adopter seems more robust there

This name will only match a batch.

>
>Maxime

Re: [linux-sunxi] Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

On Tue, Dec 15, 2020 at 06:59:33AM +0800, Icenowy Zheng wrote:
> 于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech> 写到:
> >On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> >> Early adopters' PineTabs (and all further releases) will have a new
> >LCD
> >> panel different with the one that is used when in development
> >(because
> >> the old panel's supply discontinued).
> >> 
> >> Add a new DT compatible for it.
> >> 
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> ---
> >>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> >b/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> index 6db32fbf813f..73a6c8421172 100644
> >> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> @@ -700,6 +700,11 @@ properties:
> >>            - const: pine64,pinetab
> >>            - const: allwinner,sun50i-a64
> >>  
> >> +      - description: Pine64 PineTab with new LCD panel
> >> +        items:
> >> +          - const: pine64,pinetab-new-panel
> >> +          - const: allwinner,sun50i-a64
> >> +
> >
> >We're on the right track, but new panel seems a bit too vague. What is
> >going to happen when they will change the panel again?
> >
> >pinetab-early-adopter seems more robust there
> 
> This name will only match a batch.

Look, I know the situation sucks. Can we actually move forward?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [linux-sunxi] Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

[Icenowy Zheng]

在 2020-12-16星期三的 14:00 +0100，Maxime Ripard写道：
> On Tue, Dec 15, 2020 at 06:59:33AM +0800, Icenowy Zheng wrote:
> > 于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech
> > > 写到:
> > > On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> > > > Early adopters' PineTabs (and all further releases) will have a
> > > > new
> > > LCD
> > > > panel different with the one that is used when in development
> > > (because
> > > > the old panel's supply discontinued).
> > > > 
> > > > Add a new DT compatible for it.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > index 6db32fbf813f..73a6c8421172 100644
> > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > @@ -700,6 +700,11 @@ properties:
> > > >            - const: pine64,pinetab
> > > >            - const: allwinner,sun50i-a64
> > > >  
> > > > +      - description: Pine64 PineTab with new LCD panel
> > > > +        items:
> > > > +          - const: pine64,pinetab-new-panel
> > > > +          - const: allwinner,sun50i-a64
> > > > +
> > > 
> > > We're on the right track, but new panel seems a bit too vague.
> > > What is
> > > going to happen when they will change the panel again?
> > > 
> > > pinetab-early-adopter seems more robust there
> > 
> > This name will only match a batch.
> 
> Look, I know the situation sucks. Can we actually move forward?

Descriptive name will match more things.

I think we should still have something descriptive, even if "new panel"
is too generic.

> 
> Maxime

[PATCH 2/3] arm64: allwinner: dts: a64: add DT for PineTab with new LCD panel

[Icenowy Zheng]

Further released PineTabs will have a new LCD panel that is different
with the one used in developers' samples.

Add device tree for PineTab with the new panel.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../sun50i-a64-pinetab-new-panel.dts          | 26 +++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-new-panel.dts

diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
index 211d1e9d4701..83c6d1ea197f 100644
--- a/arch/arm64/boot/dts/allwinner/Makefile
+++ b/arch/arm64/boot/dts/allwinner/Makefile
@@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-new-panel.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-new-panel.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-new-panel.dts
new file mode 100644
index 000000000000..f3da9653be3e
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-new-panel.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2020 Icenowy Zheng <icenowy@aosc.io>
+ *
+ */
+
+/dts-v1/;
+
+#include "sun50i-a64-pinetab.dts"
+
+/ {
+	model = "PineTab with new LCD panel";
+	compatible = "pine64,pinetab-new-panel", "allwinner,sun50i-a64";
+};
+
+&dsi {
+	/delete-node/ panel@0;
+
+	panel@0 {
+		compatible = "feixin,k101-im2byl02";
+		reg = <0>;
+		power-supply = <&reg_dc1sw>;
+		reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */
+		backlight = <&backlight>;
+	};
+};
-- 
2.28.0

[PATCH 3/3] dt-bindings: arm: sunxi: note that old PineTab compatible has old panel

[Icenowy Zheng]

As the old LCD panel used by PineTab developer samples are discontinued,
there won't be furtherly any more units of the sample, and this should
be noted in the document.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 73a6c8421172..9f29b5811aa1 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -695,7 +695,7 @@ properties:
           - const: pine64,pinephone-1.2
           - const: allwinner,sun50i-a64
 
-      - description: Pine64 PineTab
+      - description: Pine64 PineTab (developers' sample with old discontinued LCD panel, discontinued)
         items:
           - const: pine64,pinetab
           - const: allwinner,sun50i-a64
-- 
2.28.0

Re: [PATCH 3/3] dt-bindings: arm: sunxi: note that old PineTab compatible has old panel

[Rob Herring]

On Thu, 10 Dec 2020 16:45:58 +0800, Icenowy Zheng wrote:
> As the old LCD panel used by PineTab developer samples are discontinued,
> there won't be furtherly any more units of the sample, and this should
> be noted in the document.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/3] dt-bindings: arm: sunxi: note that old PineTab compatible has old panel

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Thu, Dec 10, 2020 at 04:45:58PM +0800, Icenowy Zheng wrote:
> As the old LCD panel used by PineTab developer samples are discontinued,
> there won't be furtherly any more units of the sample, and this should
> be noted in the document.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 73a6c8421172..9f29b5811aa1 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -695,7 +695,7 @@ properties:
>            - const: pine64,pinephone-1.2
>            - const: allwinner,sun50i-a64
>  
> -      - description: Pine64 PineTab
> +      - description: Pine64 PineTab (developers' sample with old discontinued LCD panel, discontinued)

I'm not sure it's worth mentioning it's discontinued, making it clear
it's for the developers sample is enough

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]