Re: [PATCH v3] Serial: silabs si4455 serial driver

Rob Herring
2020-12-11T23:36:05Z

On Fri, 11 Dec 2020 19:31:27 +0000, József Horváth wrote:
> This is a serial port driver for
> Silicon Labs Si4455 Sub-GHz transciver.
>
> The goal of this driver is to removing wires
> between central(linux) device and remote serial devices/sensors,
> but keeping the original user software.
> It represents regular serial interface for the user space.
>
> Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
>
> Signed-off-by: József Horváth <info@ministro.hu>
> ---
> .../staging/serial/silabs,si4455.yaml | 98 ++
> MAINTAINERS | 7 +
> drivers/tty/serial/Kconfig | 8 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/si4455.c | 1328 +++++++++++++++++
> 5 files changed, 1442 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml
> create mode 100644 drivers/tty/serial/si4455.c
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/staging/serial/silabs,si4455.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml#

See https://patchwork.ozlabs.org/patch/1415258

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.