From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: add simple-audio-mux binding
Date: Fri, 11 Dec 2020 21:27:18 +0100 [thread overview]
Message-ID: <20201211202718.GI1781038@piout.net> (raw)
In-Reply-To: <20201210020545.GA1480364@robh.at.kernel.org>
On 09/12/2020 20:05:45-0600, Rob Herring wrote:
> What's wrong with the generic mux binding and driver(s)?
>
The main issue is that the driver doesn't expose audio routes and so
DAPM can't do its job properly. Also, it is more convenient to have the
control part of the ALSA sound card which is not possible with gpio-mux.
You could argue that we can have simple-audio-mux use the mux subsystem
but we still need a new binding and driver anyway, just as we have
io-channel-mux or i2c-mux. I'm not sure this would be useful but I can
be convinced otherwise.
> > +
> > +properties:
> > + compatible:
> > + const: simple-audio-mux
> > +
> > + mux-gpios:
> > + description: |
> > + GPIOs used to select the input line.
> > +
> > + sound-name-prefix:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + description:
> > + Used as prefix for sink/source names of the component. Must be a
> > + unique string among multiple instances of the same component.
> > +
> > +required:
> > + - compatible
> > + - mux-gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + mux {
> > + compatible = "simple-audio-mux";
> > + mux-gpios = <&gpio 3 0>;
> > + };
> > --
> > 2.28.0
> >
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-12-11 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 0:15 [PATCH 1/2] dt-bindings: add simple-audio-mux binding Alexandre Belloni
2020-12-05 0:15 ` [PATCH 2/2] ASoC: add simple-mux Alexandre Belloni
2020-12-09 20:27 ` [PATCH 1/2] dt-bindings: add simple-audio-mux binding Mark Brown
2020-12-10 2:05 ` Rob Herring
2020-12-11 20:27 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211202718.GI1781038@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).