From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83692C433FE for ; Fri, 11 Dec 2020 21:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38E3322B47 for ; Fri, 11 Dec 2020 21:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733182AbgLKU2c (ORCPT ); Fri, 11 Dec 2020 15:28:32 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44505 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732005AbgLKU2C (ORCPT ); Fri, 11 Dec 2020 15:28:02 -0500 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2A68660002; Fri, 11 Dec 2020 20:27:19 +0000 (UTC) Date: Fri, 11 Dec 2020 21:27:18 +0100 From: Alexandre Belloni To: Rob Herring Cc: Mark Brown , Liam Girdwood , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: add simple-audio-mux binding Message-ID: <20201211202718.GI1781038@piout.net> References: <20201205001508.346439-1-alexandre.belloni@bootlin.com> <20201210020545.GA1480364@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210020545.GA1480364@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/12/2020 20:05:45-0600, Rob Herring wrote: > What's wrong with the generic mux binding and driver(s)? > The main issue is that the driver doesn't expose audio routes and so DAPM can't do its job properly. Also, it is more convenient to have the control part of the ALSA sound card which is not possible with gpio-mux. You could argue that we can have simple-audio-mux use the mux subsystem but we still need a new binding and driver anyway, just as we have io-channel-mux or i2c-mux. I'm not sure this would be useful but I can be convinced otherwise. > > + > > +properties: > > + compatible: > > + const: simple-audio-mux > > + > > + mux-gpios: > > + description: | > > + GPIOs used to select the input line. > > + > > + sound-name-prefix: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Used as prefix for sink/source names of the component. Must be a > > + unique string among multiple instances of the same component. > > + > > +required: > > + - compatible > > + - mux-gpios > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + mux { > > + compatible = "simple-audio-mux"; > > + mux-gpios = <&gpio 3 0>; > > + }; > > -- > > 2.28.0 > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com