devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix
@ 2020-12-14  2:47 Chris Ruehl
  2020-12-14  2:47 ` [PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties Chris Ruehl
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-14  2:47 UTC (permalink / raw)
  To: Chris Ruehl
  Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
	Heiko Stuebner, linux-kernel, linux-arm-kernel, linux-rockchip

This patchset follow up with commit 
Following the reference in vendor-prefixes.yaml, update implementation,
devicetree binding dtsi and documentation for the phy-rockchip-emmc.

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 19 ++++++++++---------
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi               |  2 +-
arch/arm64/boot/dts/rockchip/rk3399.dtsi                    |  2 +-
drivers/phy/rockchip/phy-rockchip-emmc.c                    |  6 +++---
4 files changed, 15 insertions(+), 14 deletions(-)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties
  2020-12-14  2:47 [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
@ 2020-12-14  2:47 ` Chris Ruehl
  2020-12-14  2:47 ` [PATCH 2/3] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix Chris Ruehl
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-14  2:47 UTC (permalink / raw)
  To: Chris Ruehl
  Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
	Heiko Stuebner, linux-kernel, linux-arm-kernel, linux-rockchip

Update the implementation add "rockchip," vendor prefix for the
optional dts properties. Prefix referred from vendor-prefixes.yaml

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
 drivers/phy/rockchip/phy-rockchip-emmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c
index 1e424f263e7a..2fdbc8495798 100644
--- a/drivers/phy/rockchip/phy-rockchip-emmc.c
+++ b/drivers/phy/rockchip/phy-rockchip-emmc.c
@@ -377,13 +377,13 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev)
 	rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_DISABLE;
 	rk_phy->output_tapdelay_select = PHYCTRL_OTAPDLYSEL_DEFAULT;
 
-	if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val))
+	if (!of_property_read_u32(dev->of_node, "rockchip,drive-impedance-ohm", &val))
 		rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val);
 
-	if (of_property_read_bool(dev->of_node, "enable-strobe-pulldown"))
+	if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown"))
 		rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE;
 
-	if (!of_property_read_u32(dev->of_node, "output-tapdelay-select", &val)) {
+	if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select", &val)) {
 		if (val <= PHYCTRL_OTAPDLYSEL_MAXVALUE)
 			rk_phy->output_tapdelay_select = val;
 		else
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix
  2020-12-14  2:47 [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
  2020-12-14  2:47 ` [PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties Chris Ruehl
@ 2020-12-14  2:47 ` Chris Ruehl
  2020-12-14  2:47 ` [PATCH 3/3] devicetree: dtsi: rk3399-puma.dtsi, " Chris Ruehl
  2020-12-14  2:56 ` [PATCH 0/3] rockchip: emmc: rk3399 add " Chris Ruehl
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-14  2:47 UTC (permalink / raw)
  To: Chris Ruehl
  Cc: Rob Herring, devicetree, Rob Herring, Heiko Stuebner,
	Kishon Vijay Abraham I, Vinod Koul, Johan Jonker, Jacob Chen,
	Shunqian Zheng, Chen-Yu Tsai, Carlos de Paula, Sugar Zhang,
	Boris Brezillon, linux-arm-kernel, linux-rockchip, linux-kernel

Update rk3399.dtsi with the vendor prefix referred in vendor-prefixes.yaml.
Optional property: rockchip,drive-impedance-ohm

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index f5dee5f447bb..38284686aab0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1482,7 +1482,7 @@
 			clock-names = "refclk";
 			#phy-cells = <1>;
 			resets = <&cru SRST_PCIEPHY>;
-			drive-impedance-ohm = <50>;
+			rockchip,drive-impedance-ohm = <50>;
 			reset-names = "phy";
 			status = "disabled";
 		};
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] devicetree: dtsi: rk3399-puma.dtsi, add "rockchip," vendor prefix
  2020-12-14  2:47 [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
  2020-12-14  2:47 ` [PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties Chris Ruehl
  2020-12-14  2:47 ` [PATCH 2/3] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix Chris Ruehl
@ 2020-12-14  2:47 ` Chris Ruehl
  2020-12-14  2:56 ` [PATCH 0/3] rockchip: emmc: rk3399 add " Chris Ruehl
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-14  2:47 UTC (permalink / raw)
  To: Chris Ruehl
  Cc: Rob Herring, devicetree, Rob Herring, Heiko Stuebner,
	Kishon Vijay Abraham I, Vinod Koul, Johan Jonker,
	linux-arm-kernel, linux-rockchip, linux-kernel

Update rk3399-puma.dtsi with the vendor prefix referred in
vendor-prefixes.yaml.
Optional property: rockchip,drive-impedance-ohm

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
index 4660416c8f38..b715e73f9749 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi
@@ -146,7 +146,7 @@
 
 &emmc_phy {
 	status = "okay";
-	drive-impedance-ohm = <33>;
+	rockchip,drive-impedance-ohm = <33>;
 };
 
 &gmac {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix
  2020-12-14  2:47 [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
                   ` (2 preceding siblings ...)
  2020-12-14  2:47 ` [PATCH 3/3] devicetree: dtsi: rk3399-puma.dtsi, " Chris Ruehl
@ 2020-12-14  2:56 ` Chris Ruehl
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Ruehl @ 2020-12-14  2:56 UTC (permalink / raw)
  Cc: Rob Herring, devicetree, Kishon Vijay Abraham I, Vinod Koul,
	Heiko Stuebner, linux-kernel, linux-arm-kernel, linux-rockchip


On 14/12/2020 10:47 am, Chris Ruehl wrote:
> This patchset follow up with commit
> Following the reference in vendor-prefixes.yaml, update implementation,
> devicetree binding dtsi and documentation for the phy-rockchip-emmc.
> 
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 19 ++++++++++---------
> arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi               |  2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi                    |  2 +-
> drivers/phy/rockchip/phy-rockchip-emmc.c                    |  6 +++---
> 4 files changed, 15 insertions(+), 14 deletions(-)
> 

Sorry send incomplete patch-set accidentally

v1 follow.

Chris

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-14  3:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-14  2:47 [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix Chris Ruehl
2020-12-14  2:47 ` [PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties Chris Ruehl
2020-12-14  2:47 ` [PATCH 2/3] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix Chris Ruehl
2020-12-14  2:47 ` [PATCH 3/3] devicetree: dtsi: rk3399-puma.dtsi, " Chris Ruehl
2020-12-14  2:56 ` [PATCH 0/3] rockchip: emmc: rk3399 add " Chris Ruehl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).