From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77FC4361B for ; Mon, 14 Dec 2020 09:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43B3F22838 for ; Mon, 14 Dec 2020 09:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392062AbgLNJ7r (ORCPT ); Mon, 14 Dec 2020 04:59:47 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:37111 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389596AbgLNJ7k (ORCPT ); Mon, 14 Dec 2020 04:59:40 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 3CA3A5803BB; Mon, 14 Dec 2020 04:58:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 14 Dec 2020 04:58:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=tJ2pBUOM7HX4mNiASke0sXCrwwH JFY+XjGMRsMytx4k=; b=DptJaIkFb6xX4pJjpS++AJfUOg/jdt9emOQbsI3Uepg bTujXaxpsN6t0DWiut47wtx6uy+Zo/m4gkdHCHJqU+Ozk9ulgUAqS7GCtMwsLY2i +vEBZmgnV4IpLjzk5W2G0IJXS8xFLG/T08sRnZAEF8z8O0IEltUaX42d5CsnqohN ZhDizDMoFafHstIdgsclQSq19jsi58hgbfB6C1LrGJcs4IWuEOwGTinkOM2d1+uY 0Sh8LUFM4KwRiMaQUmIONNZs4K1O1DIW+BSSX1EmJmORJPnE3Ce4G811IZ540Jpm 6Y2HO4jKnutiI1liozirCzueawI2tlbYEkH2OgkKKbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=tJ2pBU OM7HX4mNiASke0sXCrwwHJFY+XjGMRsMytx4k=; b=NtuD3qaGRjepmalY9wKp/d oarGmSmmpJlbU9+X/NDkxFhbJERI02urR4c1N2RjoZMZGWhuCTpMaO8ZFQZPbWyZ koP0p7yI/xgQa40AJ6jvc10kal6gSSNYGG6Q3dPYa14zPh5HuJjh19zk5JtZ5CrS J++slUPo0KVX7sTXLkLF5ilQCYfw0jEAyc7whxFniN/cjTfQ85sp7LRgADHounWB 81quNb94cBc0v8KmiTWfxZ64pxapbv86djal1OpiaQGcTv6QlJsU0baWHjkfbmih pjS05JlIe1DZ9MnIrns95PuASYKBKsCONfAaNYtEtx6Vf+N6QuFV2mls36vpa1kQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A7891080067; Mon, 14 Dec 2020 04:58:32 -0500 (EST) Date: Mon, 14 Dec 2020 10:58:31 +0100 From: Maxime Ripard To: Andre Przywara Cc: Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Linus Walleij , Rob Herring , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Message-ID: <20201214095831.j63nks3fqxlaw75w@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-20-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jmg23eet7qynkol6" Content-Disposition: inline In-Reply-To: <20201211011934.6171-20-andre.przywara@arm.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --jmg23eet7qynkol6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 11, 2020 at 01:19:32AM +0000, Andre Przywara wrote: > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + /* 512KiB reserved for ARM Trusted Firmware (BL31) */ > + secmon_reserved: secmon@40000000 { > + reg = <0x0 0x40000000 0x0 0x80000>; > + no-map; > + }; > + }; This should still be set by the firmware > + mmc0: mmc@4020000 { > + compatible = "allwinner,sun50i-h616-mmc", > + "allwinner,sun50i-a100-mmc"; > + reg = <0x04020000 0x1000>; > + clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>; > + clock-names = "ahb", "mmc"; > + resets = <&ccu RST_BUS_MMC0>; > + reset-names = "ahb"; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + status = "disabled"; > + #address-cells = <1>; > + #size-cells = <0>; > + }; Somewhat related: we shouldn't set the MMC speed flags in the drivers. This is biting us on the already supported SoCs, so it would be great to not repeat the same mistake with the new ones Maxime --jmg23eet7qynkol6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9c3RwAKCRDj7w1vZxhR xXu0APoConMhf8h8N9MOCajqUe5V9OCrgurcic0u5jtok4MyqwD/Rf2JY8Z+NPZ1 4Hpj8og3koEatyEEARPelpEgEOUaHAk= =p8vW -----END PGP SIGNATURE----- --jmg23eet7qynkol6--