From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91024C1B0D8 for ; Mon, 14 Dec 2020 11:43:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3603C22AB0 for ; Mon, 14 Dec 2020 11:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407730AbgLNLnD (ORCPT ); Mon, 14 Dec 2020 06:43:03 -0500 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:44129 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438197AbgLNLnA (ORCPT ); Mon, 14 Dec 2020 06:43:00 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 9EE8D580221; Mon, 14 Dec 2020 06:42:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Dec 2020 06:42:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=iiNPNEsEdF7Sa6z6H7UqKpT5vMo rbcrmTtDuIlLvEU4=; b=RN/KPZJLbZUrIVLVJ15R6PZNwGxCLjllTmX0dIGshPf edyIZgGDaZnTjoVRG2liqsZqNq+dmK82bPHAXQ4RKULMMt6CZjFU4LXSqjHgmOCj 3Uczwke2H1jFuzQl4dsxtyBV1eik6yynUuN3SaDLcf1rnjfYP1ZXZhCg0+7IM8xn 81gYE72n1AYxiX6OWMC6ufOvVzAbSX4OPP3knpXNgUAoWrFKd2UbRgLCn3ktEQWU VuqUGMWUobtehHXLgx1Dp2wyLX3nLDmOkN4mCxGYvMaL7IfOusUWVCVgCAQOufHa WrN1IEi7rJbwXrwuNjtEsfz0e4bVD1ceVYRNtHc4yMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iiNPNE sEdF7Sa6z6H7UqKpT5vMorbcrmTtDuIlLvEU4=; b=hd+YVbqjLPb+gC6M725zkX 9ADb7veUpmM90bjfm5IouUVZ1vhOdWgSD0LeXfoE6aRFcJ6Qw7nrPhVhlFI801c0 TMaTSfqcGYzVzbvnT4NsXdbh2ZfHfUk//51KbTbq11pfY5NRNiWxHPDIaBR/nRYI MysKjNwoO8q+bUxiSwstVL+fLsawdzrLzUyHAXLRMQTpW3NRFRNFXOOBZM/C94YG cAeo06MVX6U6K6mVGlJc4TFZQRK62uhwpPG3NdXvT3iHYA2nb6OS9/JI/ZyLsLBq +fhRIbbK2IRqYBxR3Mh1W7E4/IgaCcvIu9o9hemWb62hWeLD4gUl93Hj1yve3oNg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuddvudfhkeekhefgffetffelgffftdehffduffegveetffehueeivddvjedv gfevnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 7DDE124005D; Mon, 14 Dec 2020 06:42:01 -0500 (EST) Date: Mon, 14 Dec 2020 12:41:59 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org, linux-sunxi@googlegroups.com, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Jonathan Corbet , Kishon Vijay Abraham I , Vinod Koul , Helen Koike , Dafna Hirschfeld , Greg Kroah-Hartman , Philipp Zabel , Sakari Ailus , Hans Verkuil , Thomas Petazzoni , kevin.lhopital@hotmail.com Subject: Re: [PATCH v3 13/15] media: sunxi: Add support for the A83T MIPI CSI-2 controller Message-ID: <20201214114159.oqb4o5fdnnmr4n5q@gilmour> References: <20201211155708.154710-1-paul.kocialkowski@bootlin.com> <20201211155708.154710-14-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="luqjk2un2nyifiz3" Content-Disposition: inline In-Reply-To: <20201211155708.154710-14-paul.kocialkowski@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --luqjk2un2nyifiz3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 11, 2020 at 04:57:06PM +0100, Paul Kocialkowski wrote: > The A83T supports MIPI CSI-2 with a composite controller, covering > both the protocol logic and the D-PHY implementation. This controller > seems to be found on the A83T only and probably was abandoned since. >=20 > This implementation splits the protocol and D-PHY registers and > uses the PHY framework internally. The D-PHY is not registered as a > standalone PHY driver since it cannot be used with any other > controller. >=20 > There are a few notable points about the controller: > - The initialisation sequence involes writing specific magic init > values that do not seem to make any particular sense given the > concerned register fields; > - Interrupts appear to be hitting regardless of the interrupt mask > registers, which can cause a serious flood when transmission errors > occur. >=20 > Only 8-bit and 10-bit Bayer formats are currently supported. > While up to 4 internal channels to the CSI controller exist, only one > is currently supported by this implementation. >=20 > This work is based on the first version of the driver submitted by > K=E9vin L'h=F4pital, which was adapted to mainline from the Allwinner BSP. > This version integrates MIPI CSI-2 support as a standalone V4L2 subdev > instead of merging it in the sun6i-csi driver. >=20 > It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane > configuration. >=20 > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 2 +- > drivers/media/platform/sunxi/Kconfig | 1 + > drivers/media/platform/sunxi/Makefile | 1 + > .../sunxi/sun8i-a83t-mipi-csi2/Kconfig | 11 + > .../sunxi/sun8i-a83t-mipi-csi2/Makefile | 4 + > .../sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.c | 92 +++ > .../sun8i-a83t-mipi-csi2/sun8i_a83t_dphy.h | 39 ++ > .../sun8i_a83t_mipi_csi2.c | 657 ++++++++++++++++++ > .../sun8i_a83t_mipi_csi2.h | 197 ++++++ > 9 files changed, 1003 insertions(+), 1 deletion(-) > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kco= nfig > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Mak= efile > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun= 8i_a83t_dphy.c > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun= 8i_a83t_dphy.h > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun= 8i_a83t_mipi_csi2.c > create mode 100644 drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun= 8i_a83t_mipi_csi2.h >=20 > diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot= /dts/sun8i-a83t-bananapi-m3.dts > index b437eaeb91e9..bebe843a069b 100644 > --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts > +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts > @@ -151,7 +151,7 @@ port@1 { > =20 > csi_in_mipi_csi2: endpoint { > remote-endpoint =3D <&mipi_csi2_out_csi>; > - } > + }; > }; > }; > }; This looks unrelated? (and there's the same issue with the macros) Maxime --luqjk2un2nyifiz3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9dPhwAKCRDj7w1vZxhR xcPdAP9q/q7r3QMKBCP+VcvAh9TUKqtz+e1Ae6scNCnvC2TD4gD/QJvT4IfRkQ73 koqE0XhbpldU7zAAxee4lM8ofAEFhQw= =ZA9r -----END PGP SIGNATURE----- --luqjk2un2nyifiz3--