From: Rob Herring <robh@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roger Quadros <rogerq@ti.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: usb: Add new compatible string for AM64 SoC
Date: Mon, 14 Dec 2020 14:48:15 -0600 [thread overview]
Message-ID: <20201214204722.GA2365525@robh.at.kernel.org> (raw)
In-Reply-To: <20201214140109.21955-1-a-govindraju@ti.com>
On Mon, Dec 14, 2020 at 07:31:09PM +0530, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as the same USB subsystem
> is present in AM64.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> Changes since v4:
> - used oneOf instead of enum, as the schema has to convey that the strings
> ti,j721e-usb and ti,am64-usb can be used combined or seperately in the
> DT nodes.
>
> Changes since v3:
> - used enum instead of anyOf.
>
> Changes since v2:
> - added changes done over the versions.
>
> Changes since v1:
> - replaced the '\t' at the beginning of the lines with spaces as it was
> causing the dt_binding_check to fail.
>
> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 388245b91a55..21e51ceca293 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -11,8 +11,12 @@ maintainers:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: ti,j721e-usb
> + - const: ti,am64-usb
> + - items:
> + - ti,j721e-usb
> + - ti,am64-usb
^
const needed before the strings
>
> reg:
> description: module registers
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-12-14 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 14:01 [PATCH v5] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
2020-12-14 20:21 ` Rob Herring
2020-12-14 20:48 ` Rob Herring [this message]
2020-12-15 4:30 ` Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214204722.GA2365525@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).