From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Martin Kepplinger <martink@posteo.de>,
Angus Ainslie <angus@akkea.ca>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Li Yang <leoyang.li@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vinod Koul <vkoul@kernel.org>, Anson Huang <Anson.Huang@nxp.com>,
Michael Walle <michael@walle.cc>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on
Date: Tue, 15 Dec 2020 10:21:16 +0100 [thread overview]
Message-ID: <20201215092116.GE29321@kozik-lap> (raw)
In-Reply-To: <7adc87ee6a5aea7b7d635ce1a0fbc4e2d8def7ed.1607879709.git.agx@sigxcpu.org>
On Sun, Dec 13, 2020 at 06:17:13PM +0100, Guido Günther wrote:
> They power vital parts of the board and low power consumption is not
> really an issue here. It also brings things more in line with what
> Purism is using downstream.
I don't find it a proper explanation. Not all regulators power vital
parts of board. Having regulators always on makes people to skip adding
proper supplies thus not describing the HW properly.
Aligning with downstream without clear reason (just because) is also not
a good reason.
Please reduce the choice only to core regulators or describe it really
why they have to be always on.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-15 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 17:17 [PATCH 0/4] Config and device tree updates for the Librem5 Devkit Guido Günther
2020-12-13 17:17 ` [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components Guido Günther
2020-12-15 9:17 ` Krzysztof Kozlowski
2020-12-13 17:17 ` [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc Guido Günther
2020-12-15 9:18 ` Krzysztof Kozlowski
2020-12-13 17:17 ` [PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on Guido Günther
2020-12-15 9:21 ` Krzysztof Kozlowski [this message]
2020-12-13 17:17 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings Guido Günther
2020-12-15 9:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215092116.GE29321@kozik-lap \
--to=krzk@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=agx@sigxcpu.org \
--cc=angus@akkea.ca \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=michael@walle.cc \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).