devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
	shawnguo@kernel.org, robh+dt@kernel.org, p.zabel@pengutronix.de
Cc: paul.kocialkowski@bootlin.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	s.hauer@pengutronix.de, aisheng.dong@nxp.com,
	daniel.baluta@nxp.com, robert.chiras@nxp.com,
	laurentiu.palcu@nxp.com, mark.rutland@arm.com,
	devicetree@vger.kernel.org, ezequiel@collabora.com,
	laurent.pinchart+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se,
	dafna.hirschfeld@collabora.com,
	Mirela Rabulea <mirela.rabulea@nxp.com>
Subject: [PATCH v6 8/9] media: Avoid parsing quantization and huffman tables
Date: Tue, 15 Dec 2020 13:18:42 +0200	[thread overview]
Message-ID: <20201215111843.30269-9-mirela.rabulea@oss.nxp.com> (raw)
In-Reply-To: <20201215111843.30269-1-mirela.rabulea@oss.nxp.com>

From: Mirela Rabulea <mirela.rabulea@nxp.com>

These are optional in struct v4l2_jpeg_header, so skip DHT/DQT segment
parsing if huffman_tables/quantization_tables were not requested by user,
to save time.
However, do count them (num_dht/num_dqt).

Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
Changes in v6:
  Call jpeg_skip_segment() instead of jpeg_parse_quantization_table()/jpeg_parse_huffman_tables(),
  when quantization/huffman tables are not requested by user.
  Remove the NULL pointer check in the lower-level function.
  Thanks Philipp & Hans for feedback

 drivers/media/v4l2-core/v4l2-jpeg.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-jpeg.c b/drivers/media/v4l2-core/v4l2-jpeg.c
index dc9def4c2648..f3d03d39defb 100644
--- a/drivers/media/v4l2-core/v4l2-jpeg.c
+++ b/drivers/media/v4l2-core/v4l2-jpeg.c
@@ -537,6 +537,10 @@ int v4l2_jpeg_parse_header(void *buf, size_t len, struct v4l2_jpeg_header *out)
 					&out->dht[out->num_dht++ % 4]);
 			if (ret < 0)
 				return ret;
+			if (!out->huffman_tables) {
+				ret = jpeg_skip_segment(&stream);
+				break;
+			}
 			ret = jpeg_parse_huffman_tables(&stream,
 							out->huffman_tables);
 			break;
@@ -545,6 +549,10 @@ int v4l2_jpeg_parse_header(void *buf, size_t len, struct v4l2_jpeg_header *out)
 					&out->dqt[out->num_dqt++ % 4]);
 			if (ret < 0)
 				return ret;
+			if (!out->quantization_tables) {
+				ret = jpeg_skip_segment(&stream);
+				break;
+			}
 			ret = jpeg_parse_quantization_tables(&stream,
 					out->frame.precision,
 					out->quantization_tables);
-- 
2.17.1


  parent reply	other threads:[~2020-12-15 11:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 11:18 [PATCH v6 0/9] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 1/9] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 2/9] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 3/9] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 4/9] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 5/9] Add maintainer for IMX jpeg v4l2 driver Mirela Rabulea (OSS)
2020-12-15 11:18 ` [PATCH v6 6/9] media: Add parsing for APP14 data segment in jpeg helpers Mirela Rabulea (OSS)
2021-01-04 17:00   ` Philipp Zabel
2020-12-15 11:18 ` [PATCH v6 7/9] media: Quit parsing stream if doesn't start with SOI Mirela Rabulea (OSS)
2020-12-15 11:18 ` Mirela Rabulea (OSS) [this message]
2021-01-04 17:00   ` [PATCH v6 8/9] media: Avoid parsing quantization and huffman tables Philipp Zabel
2020-12-15 11:18 ` [PATCH v6 9/9] media: imx-jpeg: Use v4l2 jpeg helpers in mxc-jpeg Mirela Rabulea (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215111843.30269-9-mirela.rabulea@oss.nxp.com \
    --to=mirela.rabulea@oss.nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.palcu@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=mirela.rabulea@nxp.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robert.chiras@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).