From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE2CC4361B for ; Wed, 16 Dec 2020 13:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECEB723105 for ; Wed, 16 Dec 2020 13:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbgLPNlo (ORCPT ); Wed, 16 Dec 2020 08:41:44 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:60603 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgLPNlo (ORCPT ); Wed, 16 Dec 2020 08:41:44 -0500 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id B6850100006; Wed, 16 Dec 2020 13:41:00 +0000 (UTC) Date: Wed, 16 Dec 2020 14:41:00 +0100 From: Alexandre Belloni To: Claudiu Beznea Cc: robh+dt@kernel.org, mark.rutland@arm.com, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, sre@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc Message-ID: <20201216134100.GG2814589@piout.net> References: <1608123453-1423-1-git-send-email-claudiu.beznea@microchip.com> <1608123453-1423-3-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1608123453-1423-3-git-send-email-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/12/2020 14:57:32+0200, Claudiu Beznea wrote: > Add compatible for Microchip SAMA7G5's shutdown controller. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) I'm pretty sure the first comment you'll get is to convert this file to yaml ;) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > index 62cd4e89817c..7990358ac06e 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt > @@ -91,7 +91,8 @@ SHDWC SAMA5D2-Compatible Shutdown Controller > 1) shdwc node > > required properties: > -- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc". > +- compatible: should be "atmel,sama5d2-shdwc", "microchip,sam9x60-shdwc" or > + "microchip,sama7g5-shdwc" > - reg: should contain registers location and length > - clocks: phandle to input clock. > - #address-cells: should be one. The cell is the wake-up input index. > @@ -103,7 +104,7 @@ optional properties: > microseconds. It's usually a board-related property. > - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up. > > -optional microchip,sam9x60-shdwc properties: > +optional microchip,sam9x60-shdwc or microchip,sama7g5-shdwc properties: > - atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up. > > The node contains child nodes for each wake-up input that the platform uses. > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com