From: Mark Brown <broonie@kernel.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-spi <linux-spi@vger.kernel.org>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
nadavh@marvell.com, "Ben Peled (בן פלד)" <bpeled@marvell.com>,
"Stefan Chulski" <stefanc@marvell.com>,
"Konstantin Porotchkin" <kostap@marvell.com>
Subject: Re: [PATCH 2/3] spi: orion: enable support for switching CS every transferred byte
Date: Thu, 17 Dec 2020 14:21:27 +0000 [thread overview]
Message-ID: <20201217142127.GF4708@sirena.org.uk> (raw)
In-Reply-To: <CAPv3WKdRM_=t8Rn8LkRWTV2+WGQ3biStjmGXwfQD0z9yKR19jA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Thu, Dec 17, 2020 at 02:56:16PM +0100, Marcin Wojtas wrote:
> Regarding your comment from patch 3/3 that "spi-1byte-cs" should be
> replaced by handling based on the compatible string - do you mean
> dropping above parsing and updating SPI bus mode field with
> SPI_1BYTE_CS flag in the relevant SPI device driver?
There's more to it than that but like I said in reply to the patch
AFAICT we already support this.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-17 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 11:27 [PATCH 0/3] spi: new feature and fix for Marvell Orion driver kostap
2020-12-17 11:27 ` [PATCH 1/3] spi: orion: enable clocks before spi_setup kostap
2020-12-17 13:23 ` Mark Brown
2020-12-17 14:00 ` [EXT] " Kostya Porotchkin
2020-12-17 11:27 ` [PATCH 2/3] spi: orion: enable support for switching CS every transferred byte kostap
2020-12-17 13:56 ` Marcin Wojtas
2020-12-17 14:21 ` Mark Brown [this message]
2020-12-17 14:49 ` Marcin Wojtas
2020-12-17 14:15 ` Mark Brown
2020-12-17 14:48 ` Marcin Wojtas
2020-12-17 11:27 ` [PATCH 3/3] dt-bindings: spi: add support for spi-1byte-cs kostap
2020-12-17 13:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217142127.GF4708@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bpeled@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=jaz@semihalf.com \
--cc=kostap@marvell.com \
--cc=linux-spi@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=stefanc@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).