From: <kostap@marvell.com>
To: <linux-spi@vger.kernel.org>
Cc: <devicetree@vger.kernel.org>, <broonie@kernel.org>,
<robh+dt@kernel.org>, <mw@semihalf.com>, <jaz@semihalf.com>,
<nadavh@marvell.com>, <bpeled@marvell.com>, <stefanc@marvell.com>,
Konstantin Porotchkin <kostap@marvell.com>
Subject: [PATCH v2 2/2] spi: orion: enable support for switching CS every transferred byte
Date: Thu, 17 Dec 2020 19:09:32 +0200 [thread overview]
Message-ID: <20201217170933.10717-3-kostap@marvell.com> (raw)
In-Reply-To: <20201217170933.10717-1-kostap@marvell.com>
From: Marcin Wojtas <mw@semihalf.com>
Some SPI devices, require toggling the CS every transferred byte.
Enable such possibility in the spi-orion driver.
Note that in order to use it, in the driver of a secondary device
attached to this controller, the SPI bus 'mode' field must be
updated with SPI_CS_WORD flag before calling spi_setup() routine.
In addition to that include a work-around - some devices, such as
certain models of SLIC (Subscriber Line Interface Card),
may require extra delay after CS toggling, so add a minimal
timing relaxation in relevant places.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
---
drivers/spi/spi-orion.c | 24 +++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 3bfda4225d45..0f92dd026bee 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -369,8 +369,15 @@ orion_spi_write_read_8bit(struct spi_device *spi,
{
void __iomem *tx_reg, *rx_reg, *int_reg;
struct orion_spi *orion_spi;
+ bool cs_single_byte;
+
+ cs_single_byte = spi->mode & SPI_CS_WORD;
orion_spi = spi_master_get_devdata(spi->master);
+
+ if (cs_single_byte)
+ orion_spi_set_cs(spi, 0);
+
tx_reg = spi_reg(orion_spi, ORION_SPI_DATA_OUT_REG);
rx_reg = spi_reg(orion_spi, ORION_SPI_DATA_IN_REG);
int_reg = spi_reg(orion_spi, ORION_SPI_INT_CAUSE_REG);
@@ -384,6 +391,11 @@ orion_spi_write_read_8bit(struct spi_device *spi,
writel(0, tx_reg);
if (orion_spi_wait_till_ready(orion_spi) < 0) {
+ if (cs_single_byte) {
+ orion_spi_set_cs(spi, 1);
+ /* Satisfy some SLIC devices requirements */
+ udelay(4);
+ }
dev_err(&spi->dev, "TXS timed out\n");
return -1;
}
@@ -391,6 +403,16 @@ orion_spi_write_read_8bit(struct spi_device *spi,
if (rx_buf && *rx_buf)
*(*rx_buf)++ = readl(rx_reg);
+ if (cs_single_byte) {
+ orion_spi_set_cs(spi, 1);
+ /*
+ * Some devices, such as certain models of SLIC
+ * (Subscriber Line Interface Card)
+ * may require extra delay after CS toggling.
+ */
+ udelay(4);
+ }
+
return 1;
}
@@ -626,7 +648,7 @@ static int orion_spi_probe(struct platform_device *pdev)
}
/* we support all 4 SPI modes and LSB first option */
- master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST;
+ master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST | SPI_CS_WORD;
master->set_cs = orion_spi_set_cs;
master->transfer_one = orion_spi_transfer_one;
master->num_chipselect = ORION_NUM_CHIPSELECTS;
--
2.17.1
next prev parent reply other threads:[~2020-12-17 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 17:09 [PATCH v2 0/2] spi: new feature and fix for Marvell Orion driver kostap
2020-12-17 17:09 ` [PATCH v2 1/2] spi: orion: enable clocks before spi_setup kostap
2020-12-17 17:25 ` Mark Brown
2020-12-22 12:46 ` [EXT] " Kostya Porotchkin
2020-12-22 16:56 ` Mark Brown
2020-12-17 17:09 ` kostap [this message]
2020-12-17 17:42 ` [PATCH v2 2/2] spi: orion: enable support for switching CS every transferred byte Mark Brown
2020-12-17 17:09 ` [PATCH v2 0/2] spi: new feature and fix for Marvell Orion driver kostap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217170933.10717-3-kostap@marvell.com \
--to=kostap@marvell.com \
--cc=bpeled@marvell.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jaz@semihalf.com \
--cc=linux-spi@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=stefanc@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).