From: Rob Herring <robh@kernel.org>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: troy.kisky@boundarydevices.com, robh+dt@kernel.org,
jagan@amarulasolutions.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v2 4/7] regulator: dt-bindings: pf8x00: remove nxp,ilim-ma property
Date: Thu, 17 Dec 2020 17:51:45 -0600 [thread overview]
Message-ID: <20201217235145.GA456282@robh.at.kernel.org> (raw)
In-Reply-To: <20201215235639.31516-5-adrien.grassein@gmail.com>
On Wed, 16 Dec 2020 00:56:36 +0100, Adrien Grassein wrote:
> This property seems useless because we can use the
> regulator-max-microamp generic property to do the same
> and using generic code.
>
> The only things it changes is the default value. The original
> code was using "2100" (mA) as default one, but I think we should
> keep the value in the OTP memory as the default one. This value
> is automatically loaded in the register by the chip.
>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
> .../bindings/regulator/nxp,pf8x00-regulator.yaml | 13 -------------
> 1 file changed, 13 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-12-17 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 23:56 [PATCH v2 0/7] Fix issues on pf8x00 driver Adrien Grassein
2020-12-15 23:56 ` [PATCH v2 1/7] regulator: dt-bindings: remove useless properties Adrien Grassein
2020-12-17 17:31 ` Jagan Teki
2020-12-17 23:49 ` Rob Herring
2020-12-15 23:56 ` [PATCH v2 2/7] regulator: pf8x00: add a doc for the module Adrien Grassein
2020-12-17 17:32 ` Jagan Teki
2020-12-15 23:56 ` [PATCH v2 3/7] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc Adrien Grassein
2020-12-17 17:37 ` Jagan Teki
2020-12-17 23:51 ` Rob Herring
2020-12-15 23:56 ` [PATCH v2 4/7] regulator: dt-bindings: pf8x00: remove nxp,ilim-ma property Adrien Grassein
2020-12-17 23:51 ` Rob Herring [this message]
2020-12-15 23:56 ` [PATCH v2 5/7] regulator: " Adrien Grassein
2020-12-15 23:56 ` [PATCH v2 6/7] regulator: pf8x00: use linear range for buck 1-6 Adrien Grassein
2020-12-15 23:56 ` [PATCH v2 7/7] regulator: pf8x00: fix nxp,phase-shift Adrien Grassein
2020-12-17 17:41 ` Jagan Teki
2020-12-17 18:38 ` Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217235145.GA456282@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=adrien.grassein@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).