From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDB1C4361B for ; Fri, 18 Dec 2020 09:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBD6B23A7D for ; Fri, 18 Dec 2020 09:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733053AbgLRJh0 (ORCPT ); Fri, 18 Dec 2020 04:37:26 -0500 Received: from mail-ed1-f52.google.com ([209.85.208.52]:44445 "EHLO mail-ed1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732991AbgLRJh0 (ORCPT ); Fri, 18 Dec 2020 04:37:26 -0500 Received: by mail-ed1-f52.google.com with SMTP id p22so1632346edu.11; Fri, 18 Dec 2020 01:37:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sP5Pl2hChRWdlyFWKwCe+3kPLFBbxcwbik9e5Qyx4BY=; b=rpPsrFPG3LyZlWvSxQUshT/7cpRya/qxnQH4qPDz0CVK2///ZtsYuS7f4NnPVJLqlW 3/DOZRIrrfy6pagx8HZWX5W/0BR9vPiCNYLzWe1OxG+P9yyvE7CqCPpJc9tz7t4l/x5Z g2VHO8uLV4lnZytVoNuj7k4nN5GPhwkPVc3wGsc1stsGYF8ejDUaSbUwMZkdujB7hVBk rZOWus57a+Ab+ATji+YtvuNXuiE151CI702j80XrO9nXKa61CAf1D6mtjttwdc+wjvdz VAnIonMjn7mZutopD5BNsi1rKfw9kyo5gNGAqwruaoL8LWXd9HaymJYg1VZR0jo49dzX kxKg== X-Gm-Message-State: AOAM533Mx09eTEKZkM28271dT28ae6MGF+6XxB5upVfHGVf7c5O/uHQS w0OVs8ZYNHj9x4SA71/HKfQ= X-Google-Smtp-Source: ABdhPJwmnQ8vtF9L2mupckjV6KgdPxs54QQxzeJjbslIcDPBwDazexMhbxIle9rXr08GaKC24mHzFg== X-Received: by 2002:a50:f392:: with SMTP id g18mr3497517edm.306.1608284204006; Fri, 18 Dec 2020 01:36:44 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n9sm24449828edy.83.2020.12.18.01.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 01:36:43 -0800 (PST) Date: Fri, 18 Dec 2020 10:36:41 +0100 From: Krzysztof Kozlowski To: "Alice Guo (OSS)" Cc: "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201218093641.GA38684@kozik-lap> References: <20201218083726.16427-1-alice.guo@oss.nxp.com> <20201218085223.GA17306@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > + required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > +additionalProperties: true > > > > Don't leave comments unresolved (or resolve them against review without > > discussion). Rob asked for changing it. The same as with all schemas - you need > > to describe the missing properties. > > > > Best regards, > > Krzysztof > > Hi, > Thank you for your advice. I replied to him and let him know I remained here unchanged. There will be errors according to his suggestion. Then the solution is to correct the errors - describe missing properties - instead of ignoring the suggestion and making a resubmit right away. Best regards, Krzysztof