From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB1BC2BBD4 for ; Fri, 18 Dec 2020 14:09:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A48E523AC1 for ; Fri, 18 Dec 2020 14:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbgLROJF (ORCPT ); Fri, 18 Dec 2020 09:09:05 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:58628 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgLROJE (ORCPT ); Fri, 18 Dec 2020 09:09:04 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BIE7QVo118426; Fri, 18 Dec 2020 08:07:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1608300446; bh=wA/IAkRhLdIRaBSRU1pPDngO4Y0Z0ruPfWwrmspVvd8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=thbVVYku2XQIYVwVGBkCxFcD1Zh+uS5A6rb0wBImLMw4gY9lJ0tmoGMJcAaKRNWBj xgq9jNJfFXALLTMUpmmWmid2nVRln9kUxuPc1Xq48A67kdyu5Ohs2W6yaNEwCNDRcb gb4tmisTh6qlULRYZWjMf90qaSNyN7UgSmnmWmL0= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BIE7Qgh119557 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Dec 2020 08:07:26 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 18 Dec 2020 08:07:25 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 18 Dec 2020 08:07:25 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BIE7P1O033788; Fri, 18 Dec 2020 08:07:25 -0600 Date: Fri, 18 Dec 2020 08:07:25 -0600 From: Nishanth Menon To: Gowtham Tammana CC: , Tero Kristo , , Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries Message-ID: <20201218140725.6ierioowdufl52bv@unfilled> References: <20201217000716.11091-1-g-tammana@ti.com> <20201217000716.11091-3-g-tammana@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201217000716.11091-3-g-tammana@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18:07-20201216, Gowtham Tammana wrote: > Add DT entries for main domain watchdog instances. Please add a note to indicate that these are the only watchdogs that are visible to Linux and ARMv8 systems. You may need to repost the dts patch once you have the > > Signed-off-by: Gowtham Tammana > --- > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > index 72d6496e88dd..de430d44c2a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > @@ -303,6 +303,24 @@ main_uart9: serial@2890000 { > clock-names = "fclk"; > }; > > + watchdog0: watchdog@2200000 { If you are going to strengthen the node-names up (recommend we do that), you might want to use a regex and lock things down. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26 That is much better option that expecting people to read the example and follow the convention. > + compatible = "ti,j7-rti-wdt"; > + reg = <0x0 0x2200000 0x0 0x100>; we try and keep 0x00 instead of 0x0 -> see other places in the dtsi > + clocks = <&k3_clks 252 1>; > + power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 252 1>; > + assigned-clock-parents = <&k3_clks 252 5>; > + }; > + > + watchdog1: watchdog@2210000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x0 0x2210000 0x0 0x100>; > + clocks = <&k3_clks 253 1>; > + power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 253 1>; > + assigned-clock-parents = <&k3_clks 253 5>; > + }; > + > main_i2c0: i2c@2000000 { > compatible = "ti,j721e-i2c", "ti,omap4-i2c"; > reg = <0x00 0x2000000 0x00 0x100>; -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D