From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mfd: qca639x: add support for QCA639x powerup sequence
Date: Mon, 21 Dec 2020 09:02:44 +0000 [thread overview]
Message-ID: <20201221090244.GA53991@dell> (raw)
In-Reply-To: <20201220165845.3712599-3-dmitry.baryshkov@linaro.org>
On Sun, 20 Dec 2020, Dmitry Baryshkov wrote:
> Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part
> being controlled through the UART and WiFi being present on PCIe
> bus. Both blocks share common power sources. So add mfd device driver
> handling power sequencing of QCA6390/1.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/mfd/Kconfig | 12 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/qcom-qca639x.c | 168 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 181 insertions(+)
> create mode 100644 drivers/mfd/qcom-qca639x.c
This is not an MFD, since it utilised neither the MFD API nor
of_platform_populate() to register child devices.
Suggest you use drivers/power or similar to handle shared power
sequencing requirements.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-21 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 16:58 [PATCH 0/4] Add support for Qualcomm QCA639x chips family Dmitry Baryshkov
2020-12-20 16:58 ` [PATCH 1/4] dt-bindings: mfd: qcom,qca639x: add binding for QCA639x defvice Dmitry Baryshkov
2020-12-31 22:50 ` Rob Herring
2021-01-03 3:41 ` Dmitry Baryshkov
2021-01-14 14:33 ` Rob Herring
2021-01-14 16:55 ` Dmitry Baryshkov
2020-12-20 16:58 ` [PATCH 2/4] mfd: qca639x: add support for QCA639x powerup sequence Dmitry Baryshkov
2020-12-21 9:02 ` Lee Jones [this message]
2020-12-21 14:08 ` Dmitry Baryshkov
2020-12-22 10:16 ` Lee Jones
2020-12-31 22:52 ` Rob Herring
2020-12-20 16:58 ` [PATCH 3/4] arm64: dts: qcom: Add Bluetooth support on RB5 Dmitry Baryshkov
2020-12-20 16:58 ` [PATCH 4/4] arm64: dtb: qcom: qrb5165-rb5: add power domain to pcie0 phy Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221090244.GA53991@dell \
--to=lee.jones@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).