From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9336FC433E0 for ; Mon, 21 Dec 2020 10:06:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4907222AAB for ; Mon, 21 Dec 2020 10:06:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726120AbgLUKGW (ORCPT ); Mon, 21 Dec 2020 05:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbgLUKGW (ORCPT ); Mon, 21 Dec 2020 05:06:22 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE6FEC0613D3 for ; Mon, 21 Dec 2020 01:02:48 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id d26so10210900wrb.12 for ; Mon, 21 Dec 2020 01:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9T79yJoOT1+QdV+mhYYSVVbCJJCbFg1PwQWJR6WlAbY=; b=CrOk4paEcVPIbRLrtPVfsENnSeMvHYBK3tECGdTXy4b0hyhOnlQCD1Ha8huLL1YENp HagRLuyeQJbly0u4rdxvf4yl/YBPMG4oI5VqPQJEbdnmGTZMVpgnIby4iDUG50dBfqgJ Mve9OYb+esAAPwqe1+NiQ6NAoefDoGKfEBIRbr1oihubG6Aglpea32y0RriMDKW89KX/ WgtsKOyrHiALd9nDSOhywSa2e0oEHjMOxSHbMmLLvKcP8hHxqU0T2hkktTWDnlU1Q+6j pg59z8o924n0QoIhtuH3upONhZSrCi5FKC2qXW9OLYiRp74DIiANaAD1gahOj09a7hGl ZKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9T79yJoOT1+QdV+mhYYSVVbCJJCbFg1PwQWJR6WlAbY=; b=LnQJa/f4oAptJ51N49VjYoJG+4maCVaJ2cEIeb+rd6yKsFU+jHS0lsVo0JDtmDI1nW NmAVhoc4Z8yjxg/nG+SkanOGYTmWnh9ofKhbmL83csRdH6A/dAXGSwzCAOPoc1K0bQBe nZ23Da2+F2UtNfnaBjnLHsvuOEhu7EZuM73ktzYh6H5NXjtNT3KBi0fh31Px+NCp7yZ8 Td+7NeFqXDuKDHfrMhhoYO1KR9ZeekARdPAOUinSU6KySWpMNMkVWrqy1UeJQb2PYqIW FAh3s/uIl3+nWXexEgVOP5gmt20VRlozEp2WB5/gt29wCcdC+u56Wi3Xn+ns4vIZsel2 ebxw== X-Gm-Message-State: AOAM531byime00xQKpNG1Qdgj9P13DyGQEixYzm21NGNVbRkLUQiMNLy jjB+TQFH4Mnv4CINNFN/lto4xw== X-Google-Smtp-Source: ABdhPJzusCr9B67aMTossxbYkFkGLR2hkvsmxy7JE4yImnR5q0WhgIPr1/aGMQrBdvFp2ptpvysl3w== X-Received: by 2002:a5d:6cad:: with SMTP id a13mr17302756wra.275.1608541367389; Mon, 21 Dec 2020 01:02:47 -0800 (PST) Received: from dell ([91.110.221.144]) by smtp.gmail.com with ESMTPSA id j10sm24582598wmj.7.2020.12.21.01.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 01:02:46 -0800 (PST) Date: Mon, 21 Dec 2020 09:02:44 +0000 From: Lee Jones To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mfd: qca639x: add support for QCA639x powerup sequence Message-ID: <20201221090244.GA53991@dell> References: <20201220165845.3712599-1-dmitry.baryshkov@linaro.org> <20201220165845.3712599-3-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201220165845.3712599-3-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 20 Dec 2020, Dmitry Baryshkov wrote: > Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part > being controlled through the UART and WiFi being present on PCIe > bus. Both blocks share common power sources. So add mfd device driver > handling power sequencing of QCA6390/1. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/mfd/Kconfig | 12 +++ > drivers/mfd/Makefile | 1 + > drivers/mfd/qcom-qca639x.c | 168 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 181 insertions(+) > create mode 100644 drivers/mfd/qcom-qca639x.c This is not an MFD, since it utilised neither the MFD API nor of_platform_populate() to register child devices. Suggest you use drivers/power or similar to handle shared power sequencing requirements. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog