From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F37C433DB for ; Mon, 21 Dec 2020 10:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E022122AAB for ; Mon, 21 Dec 2020 10:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbgLUKKl (ORCPT ); Mon, 21 Dec 2020 05:10:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgLUKKl (ORCPT ); Mon, 21 Dec 2020 05:10:41 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60D6DC061282 for ; Mon, 21 Dec 2020 02:10:00 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id s26so22253405lfc.8 for ; Mon, 21 Dec 2020 02:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=gTS5XP2jtgHu359mlLvqf93EvN6ykiTeG0K5/al16QI=; b=mjZsJ0+ovrZ4dWIMP+NT0ePEC9xYzfkmqWhZkKvz4yxZd9h384IRplLWesY5RPM1zk RamBZZLwz9j33w2WiW4erYjF0mRGfRzoMjrTA/mBAglwzpAmjJdFm7dxTFZCfCU5lkvP G0rKJPdkhske3+Wou3ZgxJg5itEdSf4SvEWG3N48vDyKtWuDU1sdF9O+AsEHtgvlHMe6 pAF8gNNRNDzr3vznIdbut+C6OfwQM9rjVacBKWEhBK1Dp3PSrNIuZW0tc3r4GsKfxiD1 wah7fH8BpywxddirD/AQVMTSui5/oL/wJl/KoMqMT6Y/zPo1VW8n/49xN0nJ0U84NzQT EeZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=gTS5XP2jtgHu359mlLvqf93EvN6ykiTeG0K5/al16QI=; b=uDn+aIAiKmStXHce0NgqI+Z4sQbS5DmQ2WA1Oxnmkz8+yda58KQ6jMG6UCt4ivFLls C9pbgsFqSsaSGtGFMZGMXsM0D0YyUpyqP8I15ly5zO3a4+VHwcJ9eAYFPWjHrboY85k5 h3OZht7F3V+0EDuc88fY3+XrrP1PxD4eI2VXcR9BwCyHqow31b0Hv/M5hbZXqAaJ4RMr NQ27SBBlPcj0fYSzbDrgWLzTdBzhqrwTHfCbypbyJsT5+sInjRHpFNXdIkCMvp2YCfy6 98daHQTChed5zsTXZmW1c6HwIYpwaladEhyjYcyCpSRpCr4wt+booiI+SdHUjtOGYjlo Jf0Q== X-Gm-Message-State: AOAM530o9Pe1pjQ7LE6n0/C0CMU6lbvDZHnW/SJmVPbjdhIZGwR8NzM0 Yvy5gy8Y5ZZ5LIXdKs4Xc5DIZQ== X-Google-Smtp-Source: ABdhPJyhhhqWSrhwIpu9AoGAFII+/VTrWX273QHhmSjZOThd/9Efaca2cmV3e4dmcg7AQ2lK7fuF+w== X-Received: by 2002:ac2:482c:: with SMTP id 12mr4754844lft.37.1608545398952; Mon, 21 Dec 2020 02:09:58 -0800 (PST) Received: from localhost.localdomain (host-95-192-94-245.mobileonline.telia.com. [95.192.94.245]) by smtp.gmail.com with ESMTPSA id t14sm1980971lfl.216.2020.12.21.02.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 02:09:58 -0800 (PST) From: Robert Foss To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, robert.foss@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node Date: Mon, 21 Dec 2020 11:09:55 +0100 Message-Id: <20201221100955.148584-1-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, this issue prevented the ov8856 from probing properly as it did not respon to I2C messages. Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251 camera nodes") Signed-off-by: Robert Foss --- Changes since v1: - Bjorn: Use define instead of numeral arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 7cc236575ee2..f749672c5fdc 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -1112,11 +1112,11 @@ camera@10 { reg = <0x10>; // CAM0_RST_N - reset-gpios = <&tlmm 9 0>; + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&cam0_default>; gpios = <&tlmm 13 0>, - <&tlmm 9 0>; + <&tlmm 9 GPIO_ACTIVE_LOW>; clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; clock-names = "xvclk"; -- 2.27.0