From: Krzysztof Kozlowski <krzk@kernel.org>
To: Timon Baetz <timon.baetz@protonmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 5/6] ARM: dts: exynos: Added top-off charging regulator node for i9100
Date: Mon, 21 Dec 2020 15:23:22 +0100 [thread overview]
Message-ID: <20201221142322.GE33797@kozik-lap> (raw)
In-Reply-To: <20201221095001.595366-5-timon.baetz@protonmail.com>
On Mon, Dec 21, 2020 at 09:53:35AM +0000, Timon Baetz wrote:
> Value taken from Galaxy S2 vendor kernel [0] which always sets 200mA.
Subject: "Add", not "Added", as in Linux coding style.
>
> Also rearrange regulators based on definition in max8997.h.
>
> [0] https://github.com/krzk/linux-vendor-backup/blob/samsung/galaxy-s2-epic-4g-touch-sph-d710-exynos4210-dump/drivers/power/sec_battery_u1.c#L1525
>
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> ---
> arch/arm/boot/dts/exynos4210-i9100.dts | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
> index 586d801af0b5..fec6da64f7c1 100644
> --- a/arch/arm/boot/dts/exynos4210-i9100.dts
> +++ b/arch/arm/boot/dts/exynos4210-i9100.dts
> @@ -560,6 +560,16 @@ safe2_sreg: ESAFEOUT2 {
> regulator-boot-on;
> };
>
> + EN32KHZ_AP {
> + regulator-name = "EN32KHZ_AP";
> + regulator-always-on;
> + };
> +
> + EN32KHZ_CP {
> + regulator-name = "EN32KHZ_CP";
> + regulator-always-on;
> + };
> +
> charger_reg: CHARGER {
> regulator-name = "CHARGER";
> regulator-min-microamp = <200000>;
> @@ -573,13 +583,10 @@ chargercv_reg: CHARGER_CV {
> regulator-always-on;
> };
>
> - EN32KHZ_AP {
> - regulator-name = "EN32KHZ_AP";
> - regulator-always-on;
> - };
> -
> - EN32KHZ_CP {
> - regulator-name = "EN32KHZ_CP";
> + chargertopoff_reg: CHARGER_TOPOFF {
No need for label "chargertopoff_reg".
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-21 14:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 21:07 [PATCH 1/3] extcon: max8997: Add CHGINS and CHGRM interrupt handling Timon Baetz
2020-12-02 21:07 ` [PATCH 2/3] power: supply: max8997_charger: Set CHARGER current limit Timon Baetz
2020-12-02 21:50 ` Krzysztof Kozlowski
2020-12-05 7:54 ` Timon Baetz
2020-12-02 21:07 ` [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100 Timon Baetz
2020-12-02 22:04 ` Krzysztof Kozlowski
2020-12-03 5:46 ` Timon Bätz
2020-12-03 8:23 ` Krzysztof Kozlowski
2020-12-03 9:50 ` Krzysztof Kozlowski
2020-12-03 13:08 ` Stephan Gerhold
2020-12-21 9:53 ` [PATCH v2 1/6] extcon: max8997: Add CHGINS and CHGRM interrupt handling Timon Baetz
2020-12-21 9:53 ` [PATCH v2 2/6] power: supply: max8997_charger: Set CHARGER current limit Timon Baetz
2020-12-21 9:59 ` Lee Jones
2020-12-21 14:16 ` Krzysztof Kozlowski
2020-12-21 15:35 ` Timon Baetz
2020-12-21 15:43 ` Krzysztof Kozlowski
2020-12-21 9:53 ` [PATCH v2 3/6] ARM: dts: exynos: Fix charging regulator voltage and current for i9100 Timon Baetz
2020-12-21 14:19 ` Krzysztof Kozlowski
2020-12-21 9:53 ` [PATCH v2 4/6] ARM: dts: exynos: Added muic and charger nodes " Timon Baetz
2020-12-21 14:20 ` Krzysztof Kozlowski
2020-12-21 9:53 ` [PATCH v2 5/6] ARM: dts: exynos: Added top-off charging regulator node " Timon Baetz
2020-12-21 14:23 ` Krzysztof Kozlowski [this message]
2020-12-21 9:53 ` [PATCH v2 6/6] regulator: dt-bindings: Document max8997-pmic nodes Timon Baetz
2020-12-21 14:24 ` Krzysztof Kozlowski
2020-12-21 14:11 ` [PATCH v2 1/6] extcon: max8997: Add CHGINS and CHGRM interrupt handling Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221142322.GE33797@kozik-lap \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=timon.baetz@protonmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).