From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513ACC433E0 for ; Wed, 23 Dec 2020 19:39:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09D6D22473 for ; Wed, 23 Dec 2020 19:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728017AbgLWTjb (ORCPT ); Wed, 23 Dec 2020 14:39:31 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:44328 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgLWTjb (ORCPT ); Wed, 23 Dec 2020 14:39:31 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7EE318053B; Wed, 23 Dec 2020 20:38:41 +0100 (CET) Date: Wed, 23 Dec 2020 20:38:40 +0100 From: Sam Ravnborg To: Rob Herring Cc: devicetree@vger.kernel.org, Linux-ALSA , Greg Kroah-Hartman , Linux USB List , "linux-kernel@vger.kernel.org" , dri-devel , Jassi Brar , Vinod Koul , Mark Brown , Laurent Pinchart , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items Message-ID: <20201223193840.GA3669192@ravnborg.org> References: <20201222040645.1323611-1-robh@kernel.org> <20201222063908.GB3463004@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Itgwjo3g c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=ceURT3LBwQyT03W6ftYA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, > > With one comment below, > > Acked-by: Sam Ravnborg > > > > > --- > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > index 737c1f47b7de..54c361d4a7af 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > @@ -74,11 +74,8 @@ properties: > > > > > > phys: > > > maxItems: 1 > > > - items: > > > - - description: phandle + phy specifier pair. > > > > The description may help some people, so keeping the > > description and deleting maxItems would maybe be better. > > Do we really want to describe 'phys' hundreds of times? No. Agree, for common properties we as a minimum want a phy-common.yaml or some such - and have the description exactly once. > The > question I ask on the descriptions is could it be generated instead. That could also be an idea, but assuming most people look at the source then the same "most people" would miss the generated descriptions. But to be clear - I see that phys: is a commonly used property so no problem to have the description dropped here. Ack still stands. Sam