From: Nishanth Menon <nm@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions
Date: Mon, 4 Jan 2021 06:55:44 -0600 [thread overview]
Message-ID: <20210104125544.arluqus2xbqwacez@curler> (raw)
In-Reply-To: <20210104122232.24071-2-kishon@ti.com>
On 17:52-20210104, Kishon Vijay Abraham I wrote:
> Cadence IP in J721E supports a maximum of 32 outbound regions. However
> commit 4e5833884f66 ("arm64: dts: ti: k3-j721e-main: Add PCIe device
> tree nodes") incorrectly added this as 16 outbound regions. Now that
> "cdns,max-outbound-regions" is an optional property with default value
> as 32, remove "cdns,max-outbound-regions" from endpoint DT node.
>
> Fixes: 4e5833884f66 ("arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes")
^^ Is this a backward compatible fixup. If I were to apply this on
v5.10, wont we have a broken PCIe functionality? Drop the fixes if this
is not backward compatible fixup (unless ofcourse the driver fixup is
backported all the way back as well - I am assuming will be done in a
manner to preserve compatibility with older dtb?)
On master right now:
$ git grep "cdns,max-outbound-regions" .
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml: cdns,max-outbound-regions = <16>;
Documentation/devicetree/bindings/pci/cdns-pcie-ep.yaml: cdns,max-outbound-regions:
Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml: cdns,max-outbound-regions:
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>;
drivers/pci/controller/cadence/pcie-cadence-ep.c: of_property_read_u32(np, "cdns,max-outbound-regions", &ep->max_regions);
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-01-04 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:22 [PATCH v3 0/6] PCI: J7200/J721E PCIe bindings Kishon Vijay Abraham I
2021-01-04 12:22 ` [PATCH v3 1/6] arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions Kishon Vijay Abraham I
2021-01-04 12:55 ` Nishanth Menon [this message]
2021-01-04 12:22 ` [PATCH v3 2/6] arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for pcieX_ctrl Kishon Vijay Abraham I
2021-01-04 12:22 ` [PATCH v3 3/6] arm64: dts: ti: k3-j7200-main: Add SERDES and WIZ device tree node Kishon Vijay Abraham I
2021-01-04 12:22 ` [PATCH v3 4/6] arm64: dts: ti: k3-j7200-main: Add PCIe " Kishon Vijay Abraham I
2021-01-04 12:22 ` [PATCH v3 5/6] arm64: dts: ti: k3-j7200-common-proc-board: Enable SERDES0 Kishon Vijay Abraham I
2021-01-04 12:22 ` [PATCH v3 6/6] arm64: dts: ti: k3-j7200-common-proc-board: Enable PCIe Kishon Vijay Abraham I
2021-01-04 12:59 ` [PATCH v3 0/6] PCI: J7200/J721E PCIe bindings Nishanth Menon
2021-01-04 13:10 ` Kishon Vijay Abraham I
2021-01-04 13:16 ` Nishanth Menon
2021-01-04 13:22 ` Kishon Vijay Abraham I
2021-01-04 14:51 ` Nishanth Menon
2021-01-04 15:31 ` Kishon Vijay Abraham I
2021-01-04 15:52 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104125544.arluqus2xbqwacez@curler \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox