From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E989C433DB for ; Mon, 4 Jan 2021 15:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59D05229C4 for ; Mon, 4 Jan 2021 15:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbhADPyF (ORCPT ); Mon, 4 Jan 2021 10:54:05 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44344 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbhADPyE (ORCPT ); Mon, 4 Jan 2021 10:54:04 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 104FqPhM038339; Mon, 4 Jan 2021 09:52:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1609775545; bh=AvEBi5xx1DmxbRo6O3j4ANYvjSp7EOM7xqdjGk9Oo74=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=IqyID9wVgzja9VFeipJTUhMqMNKi1cSIXKDMX5TDh6s8kVwwtZZ0SNqEyCHd6+qqR RneSGEauxU1x3bijf6WutXFbeHVbASIcRqo7p9WffyaCJiqMdvljK8eFrQrXjtWajA 1/8uy40Juh5xcWlJUeMlnoQHb33NAdXKAaKocPKA= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 104FqP9p112190 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Jan 2021 09:52:25 -0600 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 4 Jan 2021 09:52:24 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 4 Jan 2021 09:52:24 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 104FqO9v008800; Mon, 4 Jan 2021 09:52:24 -0600 Date: Mon, 4 Jan 2021 09:52:24 -0600 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Rob Herring , , , Subject: Re: [PATCH v3 0/6] PCI: J7200/J721E PCIe bindings Message-ID: <20210104155224.iuxxrbdqy6d3ftbp@kahuna> References: <20210104122232.24071-1-kishon@ti.com> <20210104125910.qaf7vi3dx6vsne6t@backfield> <465097c1-2d38-ad45-cc32-d92c385114c5@ti.com> <20210104131642.m5rgpkhnrffq5nrx@circular> <20210104145137.wmtppcvjzu374yly@kahuna> <2c0846ff-3565-5d95-3408-b8b629a9fb48@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2c0846ff-3565-5d95-3408-b8b629a9fb48@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21:01-20210104, Kishon Vijay Abraham I wrote: > Nishanth, > > On 04/01/21 8:21 pm, Nishanth Menon wrote: > > On 18:52-20210104, Kishon Vijay Abraham I wrote: > >> Nishanth, > >> > >> On 04/01/21 6:46 pm, Nishanth Menon wrote: > >>> On 18:40-20210104, Kishon Vijay Abraham I wrote: > >>>> Nishanth, > >>>> > >>>> On 04/01/21 6:29 pm, Nishanth Menon wrote: > >>>>> On 17:52-20210104, Kishon Vijay Abraham I wrote: > >>>>>> Patch series adds DT nodes in order to get PCIe working in J7200. > >>>>>> Also includes couple of fixes for J721e. > >>>>>> > >>>>>> v1 of the patch series can be found @ [1] > >>>>>> v2 of the patch series can be found @ [2] > >>>>>> > >>>>>> Changes from v2: > >>>>>> 1) Moved serdes_refclk node out of interconnect node and also replaced > >>>>>> "_" with "-" > >>>>>> > >>>>>> Changes from v1: > >>>>>> 1) Include only the device tree patches here (the binding patch is sent > >>>>>> separately) > >>>>>> 2) Include couple of patches that fixes J721E DTS. > >>>>>> > >>>>>> [1] -> http://lore.kernel.org/r/20201102101154.13598-1-kishon@ti.com > >>>>>> [2] -> http://lore.kernel.org/r/20201210130747.25436-1-kishon@ti.com > >>>>>> > >>>>>> Kishon Vijay Abraham I (6): > >>>>>> arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions > >>>>>> arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for > >>>>>> pcieX_ctrl > >>>>>> arm64: dts: ti: k3-j7200-main: Add SERDES and WIZ device tree node > >>>>>> arm64: dts: ti: k3-j7200-main: Add PCIe device tree node > >>>>>> arm64: dts: ti: k3-j7200-common-proc-board: Enable SERDES0 > >>>>>> arm64: dts: ti: k3-j7200-common-proc-board: Enable PCIe > >>>>>> > >>>>>> .../dts/ti/k3-j7200-common-proc-board.dts | 38 ++++++ > >>>>>> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 111 ++++++++++++++++++ > >>>>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 52 ++------ > >>>>>> 3 files changed, 157 insertions(+), 44 deletions(-) > >>>>> > >>>>> > >>>>> A bit confused on the dependency here. is there something merged into > >>>>> next-20210104 that makes this series ready for pickup? is there a way > >>>>> I can get a immutable tag for driver fixups to pull so that my dts > >>>>> next is not broken for PCIe (I am assuming looking at the series that > >>>>> this is probably not a backward compatible series?)? > >>>> > >>>> There are no driver changes for the basic J7200 PCIe support and the DT > >>>> bindings are already merged [1]. > >>>> > >>>> There are few errata fixes applicable for J721E which has to be removed > >>>> for J7200 but that depends on other patches to be merged [1] but that > >>>> doesn't impact j7200 functionality. > >>>> > >>>> [1] -> > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml#n19 > >>>> [2] -> http://lore.kernel.org/r/20201230120515.2348-1-nadeem@cadence.com > >>> > >>> So, Dropping stuff like "cdns,max-outbound-regions" (change from 16 to > >>> 32) will work on older kernels? Could you do a quick sanity check on the > >>> couple of "fixes" patches in this thread is not breaking functionality > >>> introduced in the older stable kernels? > >> > >> Okay, the driver changes are done such that it works with both old DT > >> and new DT however the newer DT will not work with old kernel. So I > >> think I should drop the "Fixes" tag in the DT patches. > > > > If there is a specific stable kernel version you might like to use, you > > could use that as well for those stable tags (see [1]) > > It's not a fix that might bother people (as it doesn't impact existing > functionality), so don't think it's a candidate for stable releases. OK. please repost without the fixes tag. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D