From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: add Protonic MVT board
Date: Wed, 6 Jan 2021 08:51:23 +0100 [thread overview]
Message-ID: <20210106075123.dkutuzcycokox2xr@pengutronix.de> (raw)
In-Reply-To: <20210105023515.GH4142@dragon>
Hi Shawn,
On Tue, Jan 05, 2021 at 10:35:17AM +0800, Shawn Guo wrote:
> On Tue, Dec 01, 2020 at 08:41:25AM +0100, Oleksij Rempel wrote:
> > PRTMVT is the reference platform for Protonic industrial touchscreen terminals.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpiokeys>;
> > + autorepeat;
> > +
> > + power {
> > + label = "Power Button";
> > + gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
> > + linux,code = <116>; /* KEY_POWER */
>
> Why not just using defines?
Uff, I didn't noticed there are existing defines. Thx, done.
> > + wakeup-source;
> > + };
> > +
> > + panel {
> > + compatible = "kyo,tcg070wvlq", "lg,lb070wv8";
>
> Why do you need two compatibles for a panel? The first one seems
> undocumented.
kyo,tcg070wvlq seems to be compatible with lg,lb070wv8. Currently there
is no need for driver modification.
The kyo,tcg070wvlq documentation should be added with the patch:
"dt-bindings: display: simple: Add Kyocera tcg070wvlq panel"
https://lkml.org/lkml/2020/12/7/591
> > + backlight = <&backlight>;
> > + power-supply = <®_3v3>;
> > + video@5c {
> > + compatible = "ti,tvp5150";
> > + reg = <0x5c>;
> > +
>
> Unnecessary newline.
done
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
>
> Have a newline between properties and child node.
done
> > + tvp5150_comp0_in: endpoint {
> > + remote-endpoint = <&comp0_out>;
> > + };
> > + };
> > +
> > + /* Output port 2 is video output pad */
> > + port@2 {
> > + reg = <2>;
> > + tvp5151_to_ipu1_csi0_mux: endpoint {
> > + remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
> > + };
> > + };
> > + };
> > +
> > + gpio_pca: gpio@74 {
> > + #gpio-cells = <2>;
>
> We usually begin with 'compatible'. Can you move this line after
> 'gpio-controller' maybe?
done
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2021-01-06 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 7:41 [PATCH v2 0/2] mainline Protonic MVT board Oleksij Rempel
2020-12-01 7:41 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add " Oleksij Rempel
2020-12-09 15:43 ` Rob Herring
2020-12-01 7:41 ` [PATCH v2 2/2] ARM: dts: " Oleksij Rempel
2021-01-05 2:35 ` Shawn Guo
2021-01-06 7:51 ` Oleksij Rempel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106075123.dkutuzcycokox2xr@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).