From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 66047C433E0
	for <linux-devicetree@archiver.kernel.org>; Mon, 11 Jan 2021 00:26:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2484522AAF
	for <linux-devicetree@archiver.kernel.org>; Mon, 11 Jan 2021 00:26:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726846AbhAKA0R (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Sun, 10 Jan 2021 19:26:17 -0500
Received: from mail.kernel.org ([198.145.29.99]:42448 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726525AbhAKA0R (ORCPT <rfc822;devicetree@vger.kernel.org>);
        Sun, 10 Jan 2021 19:26:17 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DDA122AAF;
        Mon, 11 Jan 2021 00:25:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1610324736;
        bh=YiolvVj0Oj06MeZfYfFnFfa1VQSCBHbzONJiZ8RUYJ0=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=eE/WBLA3kC4awatr4XFtpL+PKzGJs9k33Fc8R1LfZdCc4JGYicUXtjR5LQd2U9SEu
         KujHRJGJ91/ThIcdsQ3xdsstwKnhKJUvzJiKThlKaQGFCBg7wpWO0zY8QDT2KEsQ6R
         YuQPoUahqOfYqgiRvk032y/9l6I0+lFpcejNDhx9xx1VsdPJ63u+CkhH8cFzmVtCBs
         hVv4qchh3XJ9HR+Mln7Mm6fm9HrKq4VPh9ogJE1ewK3rF4CGntNdTq2doI/m3GEqS8
         iqwa0sUbgSHesHD30UXMDWVoaz4fqjbn6yVaFIPPrdkg6dp1Jx0WgW4kDPle1O1M93
         Gjr+NXsQj7u6A==
Date:   Mon, 11 Jan 2021 08:25:30 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Guido =?iso-8859-1?Q?G=FCnther?= <agx@sigxcpu.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Peng Fan <peng.fan@nxp.com>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Anson Huang <Anson.Huang@nxp.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Shengjiu Wang <shengjiu.wang@nxp.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy
Message-ID: <20210111002530.GQ28365@dragon>
References: <bc2da4ab8322d5e8a44018633e0220e08d70e72e.1610297714.git.agx@sigxcpu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bc2da4ab8322d5e8a44018633e0220e08d70e72e.1610297714.git.agx@sigxcpu.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

On Sun, Jan 10, 2021 at 05:55:51PM +0100, Guido Günther wrote:
> This makes sure the clock tree setup for the dphy is not dependent on
> other components.
> 
> Without this change bringing up the display can fail like
> 
>   kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1
>   kernel: phy phy-30a00300.dphy.2: for hs_clk/ref_clk=451656000/593999998 ~ 165/217
> 
> if LCDIF doesn't set up that part of the clock tree first. This was
> noticed when testing the Librem 5 devkit with defconfig. It doesn't
> happen when modules are built in.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Applied, thanks.