From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21099C433DB for ; Thu, 14 Jan 2021 13:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E36CD23A60 for ; Thu, 14 Jan 2021 13:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbhANNsi (ORCPT ); Thu, 14 Jan 2021 08:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbhANNsh (ORCPT ); Thu, 14 Jan 2021 08:48:37 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB58BC0613D3 for ; Thu, 14 Jan 2021 05:47:56 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id y187so4752777wmd.3 for ; Thu, 14 Jan 2021 05:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=TbqE2IlRGagFgBkQ2kCkUrfXzLCjHj/NgUbyVG+QOLU=; b=OwOxLsbosDLvoLhRLZ8mzzei4v0t2XhAEbH8Iq2Sxm640+qWBEKYZm4cocQg4aGYiV Xffe/6oKYTXJTmiquE5GGTUFqyH4SWt1o3Mk/HO8mr1iB4/oJKfzT+653Fp1pZ6tPwzi S1stu6wWFThE8hKMRzYPWMNQPSVjWsmHzrcFSQebC+wFsDX7FJfNPmzHzMhUEvcJ4Cv+ by4PSWVqcLWwoS6qTTEpItMusrhWhM+A6A9T+EBRMyqDtNd1C3s6YY82pNWW5Yu/oudv zQUzIvGo47Uv1SukMAsYZkAvpT4tZhYQ7JGE+BCNysEIgarpETIZ2w3ApWtZcqTPbAU2 CxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TbqE2IlRGagFgBkQ2kCkUrfXzLCjHj/NgUbyVG+QOLU=; b=eXoeCcgBQhb8l5LufnHleTN0ZX68h4WslRG95fHJ+Hd4cja7dfaYX9B2yEg+/Lge5I ibcs8aDVFHyrrerbxD8r9c/sEq1lFNDITcIWPSTXRhS6xYhXZMETyA4TZIDamCBVTch6 yG2wqVejdeFtfLVLu15eSC5xd0kWCEbhmlma5Ye2/raJumD3enhldA39g73d4mPumx80 epnS48XJBmQkjGuA56Rm5ndO8ZU78/brvOQW+FXrqK8DS2F9BB5w+KDloT6CmhwN8SjP 2CykWifxy+Kfxt5nGhWRVS8bzZA/QWyLpk1Mjqfof/H2wVE8ROx3Vf/P4+Oyk4LjDWur wlrA== X-Gm-Message-State: AOAM530EQZ93Qxz748bX4yDQzq3Nh1p+T0ZcNgNyEyprcdI4b5ZfjorJ UKplZYz92lDitYjeteNYaDAVhQ== X-Google-Smtp-Source: ABdhPJx7eMOHq1ibtaSAKOLLhWbpBK52AbF8LO4+T4csN/v/5B1yHZ36jNUkiZ/Dhf1ZMfYjqWO/Sw== X-Received: by 2002:a1c:2905:: with SMTP id p5mr4021448wmp.156.1610632075437; Thu, 14 Jan 2021 05:47:55 -0800 (PST) Received: from dell ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id n9sm9766176wrq.41.2021.01.14.05.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 05:47:54 -0800 (PST) Date: Thu, 14 Jan 2021 13:47:53 +0000 From: Lee Jones To: Dmitry Osipenko Cc: Rob Herring , Thierry Reding , Jonathan Hunter , Dan Murphy , Sebastian Reichel , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/3] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500 Message-ID: <20210114134753.GY3975472@dell> References: <20201228160547.30562-1-digetx@gmail.com> <20201228160547.30562-3-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201228160547.30562-3-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 28 Dec 2020, Dmitry Osipenko wrote: > Acer Iconia Tab A500 is an Android tablet device, it has ENE KB930 > Embedded Controller which provides battery-gauge, LED, GPIO and some > other functions. The EC uses firmware that is specifically customized > for Acer A500. This patch adds MFD driver for the Embedded Controller > which allows to power-off / reboot the A500 device, it also provides > a common register read/write API that will be used by the sub-devices. > > Signed-off-by: Dmitry Osipenko > --- > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/acer-ec-a500.c | 202 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 214 insertions(+) > create mode 100644 drivers/mfd/acer-ec-a500.c Looks good to me: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones Do you have a merge plan? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog