devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-i3c@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Conor Culhane <conor.culhane@silvaco.com>,
	Rajeev Huralikoppi <rajeev.huralikoppi@silvaco.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: i3c: Describe Silvaco master binding
Date: Thu, 14 Jan 2021 18:55:51 +0100	[thread overview]
Message-ID: <20210114185551.5a4ef35d@xps13> (raw)
In-Reply-To: <20210111200821.GA2978830@robh.at.kernel.org>

Hi Rob,

> > +properties:
> > +  compatible:
> > +    const: silvaco,i3c-master  
> 
> Kind of generic. Only 1 version?

I appended a -v1 because I have no clue of the numbering neither if
more versions will actually come.

[...]

> > +
> > +  clocks:
> > +    items:
> > +      - description: pclk, the system clock
> > +      - description: fast_clk, for the bus
> > +      - description: slow_clk, for other events  
> 
> The names of the clocks go...

Issues corrected.

[...]

> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0  
> 
> This 2 should be defined by a bus binding. Care to convert i3c.txt?

Please see v4 of this series, which includes a converstion attempt to
i3c.yaml. I am far from comfortable with yaml schema but, let's see
what you think.

Thanks,
Miquèl

  reply	other threads:[~2021-01-14 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 16:11 [PATCH v3 0/4] Silvaco I3C master driver Miquel Raynal
2020-12-28 16:11 ` [PATCH v3 1/4] dt-bindings: Add vendor prefix for Silvaco Miquel Raynal
2020-12-28 16:11 ` [PATCH v3 2/4] dt-bindings: i3c: Describe Silvaco master binding Miquel Raynal
2021-01-11 20:08   ` Rob Herring
2021-01-14 17:55     ` Miquel Raynal [this message]
2020-12-28 16:11 ` [PATCH v3 3/4] i3c: master: svc: Add Silvaco I3C master driver Miquel Raynal
2020-12-28 16:11 ` [PATCH v3 4/4] MAINTAINERS: Add Silvaco I3C master Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114185551.5a4ef35d@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=nico@fluxnic.net \
    --cc=rajeev.huralikoppi@silvaco.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).