From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: ov5647: Fix filename
Date: Fri, 15 Jan 2021 13:04:40 +0200 [thread overview]
Message-ID: <20210115110439.GR11878@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210115110146.yu635kh4emdvbidy@uno.localdomain>
On Fri, Jan 15, 2021 at 12:01:46PM +0100, Jacopo Mondi wrote:
> Hi Kieran
>
> On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > On 15/01/2021 10:16, Jacopo Mondi wrote:
> > > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > > ov5647.yaml") renamed the bindings file but did not update the
> > > Id: field there.
> > >
> > > Fix it by using the new filename.
> > >
> > > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> >
> > I wonder if this could be automatically validated by one of the checkers
> > at some point. (I assume it isn't already).
> >
>
> The dt validation process complains
>
> ../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
>
> I can't tell if it's a newly introduced validation or it was there
> already when I renamed that file ~6 months ago and I failed to run
> validation :/
I do run checkpatch before merging but I haven't done DT validation
regularly.
--
Sakari Ailus
next prev parent reply other threads:[~2021-01-15 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:16 [PATCH] dt-bindings: media: ov5647: Fix filename Jacopo Mondi
2021-01-15 10:20 ` Kieran Bingham
2021-01-15 11:01 ` Jacopo Mondi
2021-01-15 11:04 ` Sakari Ailus [this message]
2021-01-15 15:50 ` Rob Herring
2021-01-15 15:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115110439.GR11878@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox