From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org,
Sean Anderson <seanga2@gmail.com>,
Anup Patel <anup.patel@wdc.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v12 08/17] dt-bindings: fix sifive clint compatible string
Date: Fri, 15 Jan 2021 10:07:13 -0600 [thread overview]
Message-ID: <20210115160713.GA1353145@robh.at.kernel.org> (raw)
In-Reply-To: <20210115140352.146941-9-damien.lemoal@wdc.com>
On Fri, Jan 15, 2021 at 11:03:43PM +0900, Damien Le Moal wrote:
> Fix the Sifive clint compatible string definition to make the value
> "sifive,fu540-c000-clint" optional, allowing a DT to specify only
> "sifive,clint0" for its generic implementation without any tweak.
> With this change, a Sifive clint node can now be defined as explained
> in the compatible string description.
NACK.
How do you know you'll never need some tweak? Adding it to the DT later
defeats the whole point of not having to do DT updates to implement
work-arounds and/or enhancements.
>
> Cc: Anup Patel <anup.patel@wdc.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> .../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index 2a0e9cd9fbcf..c6b1f37a2949 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -22,12 +22,13 @@ description:
>
> properties:
> compatible:
> - items:
> - - const: sifive,fu540-c000-clint
> - - const: sifive,clint0
> + oneOf:
> + - items:
> + - enum:
> + - sifive,fu540-c000-clint
> + - sifive,clint0
>
> description:
> - Should be "sifive,<chip>-clint" and "sifive,clint<version>".
> Supported compatible strings are -
> "sifive,fu540-c000-clint" for the SiFive CLINT v0 as integrated
> onto the SiFive FU540 chip, and "sifive,clint0" for the SiFive
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-15 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210115140352.146941-1-damien.lemoal@wdc.com>
2021-01-15 14:03 ` [PATCH v12 03/17] dt-bindings: fix sifive plic compatible string Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 04/17] dt-bindings: add Canaan boards compatible strings Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 05/17] dt-bindings: fix sifive gpio properties Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 06/17] dt-bindings: add resets property to dw-apb-timer Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 07/17] dt-bindings: update risc-v cpu properties Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 08/17] dt-bindings: fix sifive clint compatible string Damien Le Moal
2021-01-15 15:39 ` Rob Herring
2021-01-15 16:07 ` Rob Herring [this message]
2021-01-15 14:03 ` [PATCH v12 09/17] dt-bindings: update sifive serial Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 10/17] riscv: Update Canaan Kendryte K210 device tree Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 11/17] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 12/17] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 13/17] riscv: Add SiPeed MAIX GO " Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 14/17] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2021-01-15 14:03 ` [PATCH v12 15/17] riscv: Add Kendryte KD233 " Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115160713.GA1353145@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anup.patel@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox