From: Jonathan Cameron <jic23@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 3/3] iio: dac: ad5766: add driver support for AD5766
Date: Sat, 16 Jan 2021 17:37:07 +0000 [thread overview]
Message-ID: <20210116173707.7fdd269c@archlinux> (raw)
In-Reply-To: <20210115112105.58652-3-cristian.pop@analog.com>
On Fri, 15 Jan 2021 13:21:05 +0200
Cristian Pop <cristian.pop@analog.com> wrote:
> The AD5766/AD5767 are 16-channel, 16-bit/12-bit, voltage output dense DACs
> Digital-to-Analog converters.
>
> This change adds support for these DACs.
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
I spoke too soon. Please run a W=1 build for future cases. It tends
to pick up on little issues - in this case a plural vs singular
in the docs vs the code.
...
> +/**
> + * struct ad5766_chip_info - chip specific information
> + * @num_channels: number of channels
> + * @channel: channel specification
channels.
Fixed up and pushed out.
thanks,
Jonathan
> + */
> +struct ad5766_chip_info {
> + unsigned int num_channels;
> + const struct iio_chan_spec *channels;
> +};
next prev parent reply other threads:[~2021-01-16 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 11:21 [PATCH v6 1/3] dt-bindings: iio: dac: AD5766 yaml documentation Cristian Pop
2021-01-15 11:21 ` [PATCH v6 2/3] Documentation/ABI/testing: Add documentation for AD5766 new ABI Cristian Pop
2021-01-15 11:21 ` [PATCH v6 3/3] iio: dac: ad5766: add driver support for AD5766 Cristian Pop
2021-01-16 17:33 ` Jonathan Cameron
2021-01-16 17:37 ` Jonathan Cameron [this message]
2021-01-15 16:46 ` [PATCH v6 1/3] dt-bindings: iio: dac: AD5766 yaml documentation Rob Herring
2021-01-16 17:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116173707.7fdd269c@archlinux \
--to=jic23@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).