devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Bruno Thomsen" <bth@kamstrup.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
Date: Mon, 18 Jan 2021 14:32:53 +0800	[thread overview]
Message-ID: <20210118063252.GJ28365@dragon> (raw)
In-Reply-To: <20210111151537.12530-1-bruno.thomsen@gmail.com>

On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> RTC pcf2127 device driver has changed default behaviour of the watchdog
> feature in v5.11-rc1. Now you need to explicitly enable it with a
> device tree property, "reset-source", when used in the board design.

It sound that the existing DTBs are broken by this default behaviour
change?

> 
> Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Cc: Bruno Thomsen <bth@kamstrup.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

Applied, thanks.

Shawn

> ---
>  arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> index 84b095279e65..bd6b5285aa8d 100644
> --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> @@ -115,6 +115,7 @@ pcf2127: rtc@0 {
>  		compatible = "nxp,pcf2127";
>  		reg = <0>;
>  		spi-max-frequency = <2000000>;
> +		reset-source;
>  	};
>  };
>  
> 
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> -- 
> 2.29.2
> 

  parent reply	other threads:[~2021-01-18  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 15:15 [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset Bruno Thomsen
2021-01-12 17:29 ` Alexandre Belloni
2021-01-18  6:32 ` Shawn Guo [this message]
2021-01-18  8:12   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118063252.GJ28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bruno.thomsen@gmail.com \
    --cc=bth@kamstrup.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).