Re: [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties

Rob Herring
2021-01-14T22:55:08Z

On Thu, 14 Jan 2021 12:35:24 +0100, Maxime Ripard wrote:
> additionalProperties prevent any property not explicitly defined in the
> binding to be used. Yet, some serial properties like max-speed are valid
> and validated through the serial/serial.yaml binding.
>
> Let's change additionalProperties to unevaluatedProperties to avoid
> spurious warnings.
>
> Cc: Alistair Francis <alistair@alistair23.me>
> Cc: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/net/realtek-bluetooth.yaml

See https://patchwork.ozlabs.org/patch/1426311

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.