From: Mark Brown <broonie@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mayulong <mayulong1@huawei.com>, Rob Herring <robh+dt@kernel.org>,
devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from staging
Date: Mon, 18 Jan 2021 16:20:14 +0000 [thread overview]
Message-ID: <20210118162014.GN4455@sirena.org.uk> (raw)
In-Reply-To: <20210118170245.1bf5160f@coco.lan>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Mon, Jan 18, 2021 at 05:02:45PM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <broonie@kernel.org> escreveu:
> > If for some reason the PMIC is sufficiently fragile to need a delay
> > between enables it's not clear why the driver is doing it before
> > enabling rather than after, presumably there's issues with the regulator
> > ramping up and stabalising its output
> I don't have any datasheets or documentation from this device, except for
> the Linaro's official driver for Kernel 4.9 (from where this driver
> was originally ported), and a high-level documentation for this
> hardware at 96boards site, which doesn't cover any details.
This misses the point. To repeat, if the driver is hard coding
a delay why is the driver doing this *before* rather than *after*
enabling?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-18 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:28 [PATCH v2 00/13] Move Hisilicon 6421v600 SPMI driver set out of staging Mauro Carvalho Chehab
2021-01-18 13:28 ` [PATCH v2 09/13] spmi: hi6421-spmi-pmic: move driver from staging Mauro Carvalho Chehab
2021-01-18 13:28 ` [PATCH v2 10/13] mfd: " Mauro Carvalho Chehab
2021-01-18 15:12 ` Lee Jones
2021-01-18 15:32 ` Mauro Carvalho Chehab
2021-01-18 15:50 ` Lee Jones
2021-01-18 15:47 ` Rob Herring
2021-01-18 13:28 ` [PATCH v2 11/13] regulator: hi6421v600-regulator: move it " Mauro Carvalho Chehab
2021-01-18 13:54 ` Mark Brown
2021-01-18 16:02 ` Mauro Carvalho Chehab
2021-01-18 16:20 ` Mark Brown [this message]
2021-01-18 13:28 ` [PATCH v2 12/13] dts: hisilicon: add support for USB3 on Hikey 970 Mauro Carvalho Chehab
2021-01-18 13:28 ` [PATCH v2 13/13] dts: hisilicon: add support for the PMIC found " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118162014.GN4455@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mayulong1@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).